Do not set user config on error

dtaniwaki · dtaniwaki · commit f7cf4cb4ed3f · 2019-04-11T21:42:59.000+09:00
diff --git a/cmd/root.go b/cmd/root.go
@@ -41,11 +41,12 @@ func (gf globalFlags) WorkingEnvSpec() types.WorkingEnvSpec {
 		GhostRepo:       gf.ghostRepo,
 	}
 	userName, userEmail, err := git.GetUserConfig(globalOpts.srcDir)
-	if err != nil {
+	if err == nil {
+		workingEnvSpec.GhostUserName = userName
+		workingEnvSpec.GhostUserEmail = userEmail
+	} else {
 		log.Debug("failed to get user name and email of the source directory")
 	}
-	workingEnvSpec.GhostUserName = userName
-	workingEnvSpec.GhostUserEmail = userEmail
 	return workingEnvSpec
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,11 +41,12 @@ func (gf globalFlags) WorkingEnvSpec() types.WorkingEnvSpec {`
`41`	`41`	`GhostRepo: gf.ghostRepo,`
`42`	`42`	`}`
`43`	`43`	`userName, userEmail, err := git.GetUserConfig(globalOpts.srcDir)`
`44`		`- if err != nil {`
	`44`	`+ if err == nil {`
	`45`	`+ workingEnvSpec.GhostUserName = userName`
	`46`	`+ workingEnvSpec.GhostUserEmail = userEmail`
	`47`	`+ } else {`
`45`	`48`	`log.Debug("failed to get user name and email of the source directory")`
`46`	`49`	`}`
`47`		`- workingEnvSpec.GhostUserName = userName`
`48`		`- workingEnvSpec.GhostUserEmail = userEmail`
`49`	`50`	`return workingEnvSpec`
`50`	`51`	`}`
`51`	`52`