Skip to content

Commit 7ff643b

Browse files
authored
Merge pull request #133 from lerrytang/master
fix IndexError due to empty stack
2 parents 9502411 + 38618ae commit 7ff643b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

pfrl/agents/ppo.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def _yield_subset_of_sequences_with_fixed_number_of_items(sequences, n_items):
161161
while stack:
162162
subset = []
163163
count = 0
164-
while count < n_items:
164+
while count < n_items and stack:
165165
sequence = stack.pop()
166166
subset.append(sequence)
167167
count += len(sequence)
@@ -172,8 +172,11 @@ def _yield_subset_of_sequences_with_fixed_number_of_items(sequences, n_items):
172172
assert n_exceeds > 0
173173
subset[-1] = sequence_to_split[:-n_exceeds]
174174
stack.append(sequence_to_split[-n_exceeds:])
175-
assert sum(len(seq) for seq in subset) == n_items
176-
yield subset
175+
if sum(len(seq) for seq in subset) == n_items:
176+
yield subset
177+
else:
178+
# This ends the while loop.
179+
assert len(stack) == 0
177180

178181

179182
def _compute_explained_variance(transitions):

0 commit comments

Comments
 (0)