-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Renaming methods
Intro
Each of Dependency<T>..Dependency<T1, T2, T3, T4, T5, T6, T7, TRest> has following overloads of With methods like this (using Dependency<T> as an example):
Dependency<T, T2 ...> With<T2 ...>(T2 second ...)// corresponds toDependency<T>.Of(...)factoriesDependency<T, T2 ...> With<T2 ...>(Dependency<T2 ...> other)Dependency<T, T2 ...> With<T2 ...>(Func<T2> second ...)// corresponds toDependency<T>.From(Func<T2> second ...)factoriesDependency<T, T2 ...> With<T2 ...>(Func<IServiceProvider, T2> second ...)// corresponds toDependency<T>.From(Func<IServiceProvider, T2> second ...)factories
What to do
- For each
Dependency<...>rename all theWith<T2 ...>(T2 second ...)methods toAdd(as corresponding to theOffactories).
Keep the oldWithmethods as wrappers of the newAddmethods (directly, without creation of the inner implementation), and deprecate the old methods with"This method is obsolete. Call Add instead."message and the error set. - For each
Dependency<...>rename all theWith<T2 ...>(Dependency<T2 ...> other)methods toConcat.
Rename the correspondingInnerWithtoInnerConcat.
Keep the oldWithmethods as wrappers of the newInnerConcatmethods (with keeping validation of the arguments for null), and deprecate the old methods with"This method is obsolete. Call Concat instead."message and the error set. - Copy-paste the tests of the obsolete methods to test the new methods. Mark the obsoletes' methods as obsolete to allow their compilation.
.NET targets
Remove .NET 7.0 target
Metadata
Metadata
Labels
enhancementNew feature or requestNew feature or request