Avoid invoking non-existent helper for system stats with Crunchy Bridge (#692)

* Ignore helper process error with Crunchy Bridge

* Skip collecting system stats using helper function with Crunchy

Author: keiko713

Diff for: input/system/crunchy_bridge/system.go

@@ -17,7 +17,7 @@ func GetSystemState(ctx context.Context, server *state.Server, logger *util.Logg
 	// using the same way as a self hosted server, since the container receives a bind mount
 	// of /proc and /sys from the host. Note this excludes disk usage metrics, which we instead
 	// get from the API.
-	system = selfhosted.GetSystemState(server, logger)
+	system = selfhosted.GetSystemState(server, logger, true)
 	system.Info.Type = state.CrunchyBridgeSystem
 
 	// When API key is provided, use API to obtain extra info including disk usage metrics

Diff for: input/system/selfhosted/system.go

@@ -27,7 +27,7 @@ type helperStatus struct {
 }
 
 // GetSystemState - Gets system information about a self-hosted (physical/virtual) system
-func GetSystemState(server *state.Server, logger *util.Logger) (system state.SystemState) {
+func GetSystemState(server *state.Server, logger *util.Logger, skipHelperRun bool) (system state.SystemState) {
 	config := server.Config
 	var status helperStatus
 
@@ -36,20 +36,22 @@ func GetSystemState(server *state.Server, logger *util.Logger) (system state.Sys
 		Architecture: runtime.GOARCH,
 	}
 
-	statusBytes, err := exec.Command("/usr/bin/pganalyze-collector-helper", "status", config.DbDataDirectory).Output()
-	if err != nil {
-		server.SelfTest.MarkCollectionAspectError(state.CollectionAspectSystemStats, "error running system stats helper process: %s", err)
-		logger.PrintVerbose("Selfhosted/System: Could not run helper process: %s", err)
-	} else {
-		err = json.Unmarshal(statusBytes, &status)
+	if !skipHelperRun {
+		statusBytes, err := exec.Command("/usr/bin/pganalyze-collector-helper", "status", config.DbDataDirectory).Output()
 		if err != nil {
-			server.SelfTest.MarkCollectionAspectError(state.CollectionAspectSystemStats, "error reading system stats helper output: %s", err)
-			logger.PrintVerbose("Selfhosted/System: Could not unmarshal helper status: %s", err)
-		}
+			server.SelfTest.MarkCollectionAspectError(state.CollectionAspectSystemStats, "error running system stats helper process: %s", err)
+			logger.PrintVerbose("Selfhosted/System: Could not run helper process: %s", err)
+		} else {
+			err = json.Unmarshal(statusBytes, &status)
+			if err != nil {
+				server.SelfTest.MarkCollectionAspectError(state.CollectionAspectSystemStats, "error reading system stats helper output: %s", err)
+				logger.PrintVerbose("Selfhosted/System: Could not unmarshal helper status: %s", err)
+			}
 
-		system.XlogUsedBytes = status.XlogUsedBytes
-		system.Info.SelfHosted.DatabaseSystemIdentifier = status.SystemIdentifier
-		system.Info.ClusterID = status.SystemIdentifier
+			system.XlogUsedBytes = status.XlogUsedBytes
+			system.Info.SelfHosted.DatabaseSystemIdentifier = status.SystemIdentifier
+			system.Info.ClusterID = status.SystemIdentifier
+		}
 	}
 
 	hostInfo, err := host.Info()

Diff for: input/system/system.go

@@ -55,7 +55,7 @@ func GetSystemState(ctx context.Context, server *state.Server, logger *util.Logg
 	} else if config.SystemType == "tembo" {
 		system = tembo.GetSystemState(ctx, server, logger)
 	} else if dbHost == "" || dbHost == "localhost" || dbHost == "127.0.0.1" || config.AlwaysCollectSystemData {
-		system = selfhosted.GetSystemState(server, logger)
+		system = selfhosted.GetSystemState(server, logger, false)
 	} else {
 		if opts.TestRun {
 			// Detected as self hosted, but not collecting system state as we