issue about null pointer dereference

QiuYitai · QiuYitai · commit 3244106e9629 · 2025-04-02T19:50:53.000+08:00
diff --git a/src/postgres_deparse.c b/src/postgres_deparse.c
@@ -1524,6 +1524,8 @@ static void deparseAlterIdentityColumnOptionList(StringInfo str, List *l)
 		else if (strcmp(def_elem->defname, "generated") == 0)
 		{
 			appendStringInfoString(str, "SET GENERATED ");
+			if(def_elem->arg == NULL)
+				elog(ERROR, "missing argument for identity generation specification");
 			if (intVal(def_elem->arg) == ATTRIBUTE_IDENTITY_ALWAYS)
 				appendStringInfoString(str, "ALWAYS");
 			else if (intVal(def_elem->arg) == ATTRIBUTE_IDENTITY_BY_DEFAULT)

Original file line number	Diff line number	Diff line change
`@@ -1524,6 +1524,8 @@ static void deparseAlterIdentityColumnOptionList(StringInfo str, List *l)`
`1524`	`1524`	`else if (strcmp(def_elem->defname, "generated") == 0)`
`1525`	`1525`	`{`
`1526`	`1526`	`appendStringInfoString(str, "SET GENERATED ");`
	`1527`	`+ if(def_elem->arg == NULL)`
	`1528`	`+ elog(ERROR, "missing argument for identity generation specification");`
`1527`	`1529`	`if (intVal(def_elem->arg) == ATTRIBUTE_IDENTITY_ALWAYS)`
`1528`	`1530`	`appendStringInfoString(str, "ALWAYS");`
`1529`	`1531`	`else if (intVal(def_elem->arg) == ATTRIBUTE_IDENTITY_BY_DEFAULT)`