fix skipped console autocomplete test (elastic#229274)

## Summary

Closes elastic#227576.

Discovered this whilst attempting to backport this PR
elastic#229083, I made some fixes in the
aforementioned PR then cherry-picked them unto main, and made a couple
of more fixes

<!--
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

-->

Author: eokoneyo

src/platform/test/functional/apps/console/_autocomplete.ts

@@ -23,8 +23,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     // Prompt autocomplete for 'settings'
     await PageObjects.console.promptAutocomplete('s');
 
-    await retry.waitFor('autocomplete to be visible', () =>
-      PageObjects.console.isAutocompleteVisible()
+    await retry.waitFor(
+      'autocomplete to be visible',
+      async () => await PageObjects.console.isAutocompleteVisible()
     );
     await PageObjects.console.pressEnter();
     await retry.try(async () => {
@@ -34,8 +35,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     });
   }
 
-  // Failing: See https://github.com/elastic/kibana/issues/227576
-  describe.skip('console autocomplete feature', function describeIndexTests() {
+  describe('console autocomplete feature', function describeIndexTests() {
     before(async () => {
       log.debug('navigateTo console');
       await PageObjects.common.navigateToApp('console');
@@ -57,7 +57,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.console.pressEnter();
       await PageObjects.console.sleepForDebouncePeriod();
       await PageObjects.console.promptAutocomplete();
-      expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
+      expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
     });
 
     it('correctly autocompletes inline JSON', async () => {
@@ -69,8 +69,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.console.promptAutocomplete('e');
 
       // 3) Wait for the autocomplete suggestions to appear
-      await retry.waitFor('autocomplete to be visible', () =>
-        PageObjects.console.isAutocompleteVisible()
+      await retry.waitFor(
+        'autocomplete to be visible',
+        async () => await PageObjects.console.isAutocompleteVisible()
       );
 
       // 4) Press Enter to accept the first suggestion (likely "term")
@@ -97,14 +98,19 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await PageObjects.console.pressEnter();
       await PageObjects.console.sleepForDebouncePeriod();
       await PageObjects.console.enterText(`"`);
-      expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
+      await retry.waitFor(
+        'autocomplete to be visible',
+        async () => await PageObjects.console.isAutocompleteVisible()
+      );
 
       // Iterate on the first 10 suggestions (the ones that are only visible without scrolling)
-      const suggestions = [];
+      const suggestionsPromise = [];
       for (let i = 0; i < 10; i++) {
-        suggestions.push(await PageObjects.console.getAutocompleteSuggestion(i));
+        suggestionsPromise.push(PageObjects.console.getAutocompleteSuggestion(i));
       }
 
+      const suggestions = await Promise.all(suggestionsPromise);
+
       // and expect the array to not have duplicates
       expect(suggestions).to.eql(_.uniq(suggestions));
     });
@@ -126,9 +132,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           log.debug('Key type "%s"', char);
           await PageObjects.console.enterText(char);
 
-          await retry.waitFor('autocomplete to be visible', () =>
-            PageObjects.console.isAutocompleteVisible()
+          await retry.waitFor(
+            'autocomplete to be visible',
+            async () => await PageObjects.console.isAutocompleteVisible()
           );
+
           expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
 
           for (const [i, method] of methods.entries()) {
@@ -155,8 +163,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             await PageObjects.console.enterText(char);
           }
 
-          await retry.waitFor('autocomplete to be visible', () =>
-            PageObjects.console.isAutocompleteVisible()
+          await retry.waitFor(
+            'autocomplete to be visible',
+            async () => await PageObjects.console.isAutocompleteVisible()
           );
           expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
 
@@ -180,8 +189,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           log.debug('Key type "%s"', char);
           await PageObjects.console.enterText(char);
         }
-        await retry.waitFor('autocomplete to be visible', () =>
-          PageObjects.console.isAutocompleteVisible()
+        await retry.waitFor(
+          'autocomplete to be visible',
+          async () => await PageObjects.console.isAutocompleteVisible()
         );
         expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
         await PageObjects.console.pressEnter();
@@ -212,8 +222,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           log.debug('Key type "%s"', char);
           await PageObjects.console.enterText(char);
         }
-        await retry.waitFor('autocomplete to be visible', () =>
-          PageObjects.console.isAutocompleteVisible()
+        await retry.waitFor(
+          'autocomplete to be visible',
+          async () => await PageObjects.console.isAutocompleteVisible()
         );
         expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
 
@@ -272,8 +283,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             await PageObjects.console.sleepForDebouncePeriod();
             log.debug('Key type "%s"', char);
             await PageObjects.console.enterText(char); // e.g. 'P' -> 'Po' -> 'Pos'
-            await retry.waitFor('autocomplete to be visible', () =>
-              PageObjects.console.isAutocompleteVisible()
+            await retry.waitFor(
+              'autocomplete to be visible',
+              async () => await PageObjects.console.isAutocompleteVisible()
             );
             expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
           }
@@ -284,8 +296,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             await PageObjects.console.enterText(char!); // e.g. 'Post ' -> 'Post _'
           }
 
-          await retry.waitFor('autocomplete to be visible', () =>
-            PageObjects.console.isAutocompleteVisible()
+          await retry.waitFor(
+            'autocomplete to be visible',
+            async () => await PageObjects.console.isAutocompleteVisible()
           );
           expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
         }
@@ -300,8 +313,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
           await PageObjects.console.enterText(char); // i.e. 'GET .kibana/' -> 'GET .kibana/_'
         }
 
-        await retry.waitFor('autocomplete to be visible', () =>
-          PageObjects.console.isAutocompleteVisible()
+        await retry.waitFor(
+          'autocomplete to be visible',
+          async () => await PageObjects.console.isAutocompleteVisible()
         );
         expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
       });
@@ -317,8 +331,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         log.debug('Key type Ctrl+SPACE');
         await PageObjects.console.pressCtrlSpace();
 
-        await retry.waitFor('autocomplete to be visible', () =>
-          PageObjects.console.isAutocompleteVisible()
+        await retry.waitFor(
+          'autocomplete to be visible',
+          async () => await PageObjects.console.isAutocompleteVisible()
         );
         expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
       });
@@ -438,7 +453,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.console.enterText(`POST _query\n`);
         await PageObjects.console.enterText(`{\n\t"query": """`);
         await PageObjects.console.sleepForDebouncePeriod();
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
+        await retry.waitFor(
+          'autocomplete to be visible',
+          async () => await PageObjects.console.isAutocompleteVisible()
+        );
         const suggestions = await PageObjects.console.getAllAutocompleteSuggestions();
         expect(suggestions).to.contain('FROM');
         expect(suggestions).to.contain('ROW');
@@ -450,7 +468,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.console.enterText(`{\n\t"script": """`);
         await PageObjects.console.pressEnter();
         await PageObjects.console.sleepForDebouncePeriod();
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
       });
 
       it('does not suggest ESQL in other parts of the request', async () => {
@@ -459,8 +477,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.console.pressEnter();
         await PageObjects.console.sleepForDebouncePeriod();
         await PageObjects.console.promptAutocomplete();
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
-        const suggestions = PageObjects.console.getAllAutocompleteSuggestions();
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(true);
+        const suggestions = await PageObjects.console.getAllAutocompleteSuggestions();
         expect(suggestions).to.not.contain('FROM');
         expect(suggestions).to.not.contain('ROW');
         expect(suggestions).to.not.contain('SHOW');
@@ -477,29 +495,29 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await PageObjects.console.enterText(`# GET /`);
         await PageObjects.console.sleepForDebouncePeriod();
 
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
       });
 
       it('a simple double slash comment', async () => {
         await PageObjects.console.enterText(`// GET /`);
         await PageObjects.console.sleepForDebouncePeriod();
 
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
       });
 
       it('a single line block comment', async () => {
         await PageObjects.console.enterText(`/* GET /`);
         await PageObjects.console.sleepForDebouncePeriod();
 
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
       });
 
       it('a multiline block comment', async () => {
         await PageObjects.console.enterText(`/*
           GET /`);
         await PageObjects.console.sleepForDebouncePeriod();
 
-        expect(PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
+        expect(await PageObjects.console.isAutocompleteVisible()).to.be.eql(false);
       });
     });
   });

src/platform/test/functional/page_objects/console_page.ts

@@ -85,18 +85,25 @@ export class ConsolePageObject extends FtrService {
   public async promptAutocomplete(letter = 'b') {
     const textArea = await this.getTextArea();
     await textArea.type(letter);
-    await this.retry.waitFor('autocomplete to be visible', () => this.isAutocompleteVisible());
+    await this.retry.waitFor(
+      'autocomplete to be visible',
+      async () => await this.isAutocompleteVisible()
+    );
   }
 
   public async isAutocompleteVisible() {
     const element = await this.find.byClassName('suggest-widget').catch(() => null);
     if (!element) return false;
 
-    const attribute = await element.getAttribute('style');
-    return !attribute?.includes('display: none;');
+    return await element.isDisplayed();
   }
 
   public async getAutocompleteSuggestion(index: number) {
+    await this.retry.waitFor(
+      'verify suggestions widget is displayed',
+      async () => await this.isAutocompleteVisible()
+    );
+
     const suggestionsWidget = await this.find.byClassName('suggest-widget');
     const suggestions = await suggestionsWidget.findAllByClassName('monaco-list-row');
     const suggestion = suggestions[index];