Remove FF for gap auto fill schedule (elastic#249530)

## Remove FF for gap auto fill schedule

Make gap auto fill scheduler feature available by default

Author: nkhristinin

x-pack/platform/plugins/shared/alerting/server/plugin.ts

@@ -437,15 +437,13 @@ export class AlertingPlugin {
       });
     }
 
-    if (this?.config?.gapAutoFillScheduler?.enabled ?? false) {
-      registerGapAutoFillSchedulerTask({
-        taskManager: plugins.taskManager,
-        logger: this.logger,
-        getRulesClientWithRequest: (request) => this?.getRulesClientWithRequest?.(request),
-        eventLogger: this.eventLogger!,
-        schedulerConfig: this.config.gapAutoFillScheduler,
-      });
-    }
+    registerGapAutoFillSchedulerTask({
+      taskManager: plugins.taskManager,
+      logger: this.logger,
+      getRulesClientWithRequest: (request) => this?.getRulesClientWithRequest?.(request),
+      eventLogger: this.eventLogger!,
+      schedulerConfig: this.config.gapAutoFillScheduler,
+    });
 
     // Routes
     const router = core.http.createRouter<AlertingRequestHandlerContext>();

x-pack/platform/plugins/shared/alerting/server/routes/index.ts

@@ -168,13 +168,11 @@ export function defineRoutes(opts: RouteOptions) {
   getRuleIdsWithGapsRoute(router, licenseState);
   getGapsSummaryByRuleIdsRoute(router, licenseState);
 
-  if (alertingConfig?.gapAutoFillScheduler?.enabled) {
-    createAutoFillSchedulerRoute(router, licenseState);
-    getAutoFillSchedulerRoute(router, licenseState);
-    updateAutoFillSchedulerRoute(router, licenseState);
-    deleteAutoFillSchedulerRoute(router, licenseState);
-    findAutoFillSchedulerLogsRoute(router, licenseState);
-  }
+  createAutoFillSchedulerRoute(router, licenseState);
+  getAutoFillSchedulerRoute(router, licenseState);
+  updateAutoFillSchedulerRoute(router, licenseState);
+  deleteAutoFillSchedulerRoute(router, licenseState);
+  findAutoFillSchedulerLogsRoute(router, licenseState);
 
   // Rules Settings APIs
   if (alertingConfig.rulesSettings.enabled) {

x-pack/platform/test/alerting_api_integration/common/config.ts

@@ -352,7 +352,6 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions)
         serverArgs: [
           ...xPackApiIntegrationTestsConfig.get('kbnTestServer.serverArgs'),
           ...(options.publicBaseUrl ? ['--server.publicBaseUrl=https://localhost:5601'] : []),
-          '--xpack.alerting.gapAutoFillScheduler.enabled=true',
           `--xpack.actions.allowedHosts=${JSON.stringify([
             'localhost',
             'some.non.existent.com',

x-pack/platform/test/plugin_api_integration/test_suites/task_manager/check_registered_task_types.ts

@@ -203,6 +203,7 @@ export default function ({ getService }: FtrProviderContext) {
         'fleet:update_agent_tags:retry',
         'fleet:upgrade-agentless-deployments-task',
         'fleet:upgrade_action:retry',
+        'gap-auto-fill-scheduler-task',
         'logs-data-telemetry',
         'maintenance-window:generate-events',
         'osquery:telemetry-configs',

x-pack/solutions/security/plugins/security_solution/common/experimental_features.ts

@@ -210,10 +210,6 @@ export const allowedExperimentalValues = Object.freeze({
    */
   trialCompanionEnabled: false,
 
-  /*
-   * Enables the Gap Auto Fill Scheduler feature.
-   */
-  gapAutoFillSchedulerEnabled: false,
   /**
    * Enables DNS events toggle for Linux in Endpoint policy configuration.
    * When disabled, DNS field is not added to Linux policies and not shown in UI.

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/logic/use_gap_auto_fill_capabilities.test.tsx

@@ -65,15 +65,6 @@ describe('useGapAutoFillCapabilities', () => {
     expect(result.current.canEditGapAutoFill).toBe(false);
   });
 
-  it('denies access when experimental feature flag is disabled', () => {
-    mockUseIsExperimentalFeatureEnabled.mockReturnValue(false);
-
-    const { result } = renderHook(() => useGapAutoFillCapabilities());
-
-    expect(result.current.canAccessGapAutoFill).toBe(false);
-    expect(result.current.canEditGapAutoFill).toBe(false);
-  });
-
   it('denies edit rights when license is enterprise but user lacks CRUD', () => {
     mockUseLicense.mockReturnValue({
       isEnterprise: () => true,

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_gaps/logic/use_gap_auto_fill_capabilities.ts

@@ -9,7 +9,6 @@ import { useMemo } from 'react';
 import { ProductFeatureSecurityKey } from '@kbn/security-solution-features/keys';
 import { useLicense } from '../../../common/hooks/use_license';
 import { useUserPrivileges } from '../../../common/components/user_privileges';
-import { useIsExperimentalFeatureEnabled } from '../../../common/hooks/use_experimental_features';
 import { useProductFeatureKeys } from '../../../common/hooks/use_product_feature_keys';
 
 /**
@@ -18,9 +17,6 @@ import { useProductFeatureKeys } from '../../../common/hooks/use_product_feature
 export const useGapAutoFillCapabilities = () => {
   const license = useLicense();
   const productFeatureKeys = useProductFeatureKeys();
-  const gapAutoFillSchedulerEnabled = useIsExperimentalFeatureEnabled(
-    'gapAutoFillSchedulerEnabled'
-  );
   const hasEnterpriseLicense = license.isEnterprise();
   const hasRuleGapsAutoFillFeature = productFeatureKeys.has(
     ProductFeatureSecurityKey.ruleGapsAutoFill
@@ -30,23 +26,9 @@ export const useGapAutoFillCapabilities = () => {
   return useMemo(
     () => ({
       hasEnterpriseLicense,
-      canAccessGapAutoFill:
-        gapAutoFillSchedulerEnabled &&
-        hasEnterpriseLicense &&
-        hasRuleGapsAutoFillFeature &&
-        canReadRules,
-      canEditGapAutoFill:
-        gapAutoFillSchedulerEnabled &&
-        hasEnterpriseLicense &&
-        hasRuleGapsAutoFillFeature &&
-        canEditRules,
+      canAccessGapAutoFill: hasEnterpriseLicense && hasRuleGapsAutoFillFeature && canReadRules,
+      canEditGapAutoFill: hasEnterpriseLicense && hasRuleGapsAutoFillFeature && canEditRules,
     }),
-    [
-      gapAutoFillSchedulerEnabled,
-      hasEnterpriseLicense,
-      hasRuleGapsAutoFillFeature,
-      canEditRules,
-      canReadRules,
-    ]
+    [hasEnterpriseLicense, hasRuleGapsAutoFillFeature, canEditRules, canReadRules]
   );
 };

x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_gaps/auto_gap_fill.cy.ts

@@ -78,16 +78,6 @@ describe.skip(
   'Rule gaps auto fill status',
   {
     tags: ['@ess'],
-    env: {
-      ftrConfig: {
-        kbnServerArgs: [
-          '--xpack.alerting.gapAutoFillScheduler.enabled=true',
-          `--xpack.securitySolution.enableExperimental=${JSON.stringify([
-            'gapAutoFillSchedulerEnabled',
-          ])}`,
-        ],
-      },
-    },
   },
   () => {
     describe('Platinum user flows', () => {

x-pack/solutions/security/test/security_solution_cypress/cypress/e2e/detection_response/detection_engine/rule_gaps/auto_gap_fill_basic_license.cy.ts

@@ -23,16 +23,6 @@ describe(
   'Rule gaps auto fill status - Basic license',
   {
     tags: ['@ess'],
-    env: {
-      ftrConfig: {
-        kbnServerArgs: [
-          '--xpack.alerting.gapAutoFillScheduler.enabled=true',
-          `--xpack.securitySolution.enableExperimental=${JSON.stringify([
-            'gapAutoFillSchedulerEnabled',
-          ])}`,
-        ],
-      },
-    },
   },
   () => {
     beforeEach(() => {