Update deprecated scout tags + ESLint rule (elastic#258203)

## Summary

This PR updates Scout tags from deprecated ones to the new ones and add
ESLint rule to prevent old tags used again (probably only temporarily
needed). **Wrong tagging caused tests not to run on Kibana CI**

Some `kbn-streamlang-tests` were skipped because they became out-dated
while not run on CI elastic#258476

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Alex Szabo <alex.szabo@elastic.co>

Author: 3 people

.eslintrc.js

@@ -2758,12 +2758,13 @@ module.exports = {
     },
     // Custom rules for scout tests
     {
-      // Platform & Solutions
+      // Platform & Solutions (plugins and packages, excluding Scout framework's own tests)
       files: [
-        'src/platform/plugins/**/test/{scout,scout_*}/**/*.ts',
-        'x-pack/platform/**/plugins/**/test/{scout,scout_*}/**/*.ts',
-        'x-pack/solutions/**/plugins/**/test/{scout,scout_*}/**/*.ts',
+        'src/platform/{packages,plugins}/**/test/{scout,scout_*}/**/*.ts',
+        'x-pack/platform/{packages,plugins}/**/test/{scout,scout_*}/**/*.ts',
+        'x-pack/solutions/**/{packages,plugins}/**/test/{scout,scout_*}/**/*.ts',
       ],
+      excludedFiles: ['src/platform/packages/shared/kbn-scout/test/**'],
       rules: {
         '@kbn/eslint/scout_no_describe_configure': 'error',
         '@kbn/eslint/scout_max_one_describe': 'error',
@@ -2772,6 +2773,7 @@ module.exports = {
         '@kbn/eslint/scout_no_es_archiver_in_parallel_tests': 'error',
         '@kbn/eslint/scout_no_cross_boundary_imports': 'error',
         '@kbn/eslint/scout_expect_import': 'error',
+        '@kbn/eslint/scout_no_deprecated_tags': 'error',
         '@kbn/eslint/scout_no_locators': ['error', { restricted: ['globalLoadingIndicator'] }],
         '@kbn/eslint/require_include_in_check_a11y': 'warn',
       },

packages/kbn-eslint-plugin-eslint/index.js

@@ -30,6 +30,7 @@ module.exports = {
     scout_require_global_setup_hook_in_parallel_tests: require('./rules/scout_require_global_setup_hook_in_parallel_tests'),
     scout_no_es_archiver_in_parallel_tests: require('./rules/scout_no_es_archiver_in_parallel_tests'),
     scout_expect_import: require('./rules/scout_expect_import'),
+    scout_no_deprecated_tags: require('./rules/scout_no_deprecated_tags'),
     scout_no_cross_boundary_imports: require('./rules/scout_no_cross_boundary_imports'),
     scout_no_locators: require('./rules/scout_no_locators'),
     require_kbn_fs: require('./rules/require_kbn_fs'),

packages/kbn-eslint-plugin-eslint/rules/scout_no_deprecated_tags.js

@@ -0,0 +1,102 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+/** @typedef {import("eslint").Rule.RuleModule} Rule */
+/** @typedef {import("@typescript-eslint/typescript-estree").TSESTree.CallExpression} CallExpression */
+
+const DEPRECATED_TAGS = ['@ess', '@svlOblt', '@svlSecurity', '@svlSearch'];
+
+const ERROR_MSG =
+  'Use the `tags` helper from @kbn/scout (e.g. `tags.stateful.classic`, `tags.serverless.observability.complete`) instead of deprecated string tags like `@ess` or `@svlOblt`.';
+
+/**
+ * Checks if a node represents a method describe() call (e.g., test.describe, apiTest.describe)
+ * @param {CallExpression} node
+ * @returns {boolean}
+ */
+const isDescribeCall = (node) => {
+  return (
+    node.callee.type === 'MemberExpression' &&
+    node.callee.property.type === 'Identifier' &&
+    node.callee.property.name === 'describe'
+  );
+};
+
+/**
+ * Extracts string literals from an AST node (handles array elements and spread).
+ * @param {import('@typescript-eslint/typescript-estree').TSESTree.Node} node
+ * @returns {string[]}
+ */
+const getStringLiteralsFromNode = (node) => {
+  if (!node) return [];
+
+  if (node.type === 'ArrayExpression') {
+    return node.elements.flatMap((el) => getStringLiteralsFromNode(el));
+  }
+
+  if (node.type === 'Literal' && typeof node.value === 'string') {
+    return [node.value];
+  }
+
+  return [];
+};
+
+/** @type {Rule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description:
+        'Disallow deprecated Scout test tags (@ess, @svlOblt, @svlSecurity, @svlSearch). Use the `tags` helper from @kbn/scout instead.',
+      category: 'Best Practices',
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      deprecatedTag: ERROR_MSG,
+    },
+  },
+
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (!isDescribeCall(node) || node.arguments.length < 2) {
+          return;
+        }
+
+        const optionsArg = node.arguments[1];
+        if (optionsArg.type !== 'ObjectExpression') {
+          return;
+        }
+
+        const tagProperty = optionsArg.properties.find(
+          (prop) =>
+            prop.type === 'Property' && prop.key.type === 'Identifier' && prop.key.name === 'tag'
+        );
+
+        if (!tagProperty || tagProperty.type !== 'Property') {
+          return;
+        }
+
+        const tagValue = tagProperty.value;
+        const stringLiterals = getStringLiteralsFromNode(tagValue);
+
+        for (const literal of stringLiterals) {
+          if (DEPRECATED_TAGS.includes(literal)) {
+            context.report({
+              node: tagProperty,
+              messageId: 'deprecatedTag',
+            });
+            return;
+          }
+        }
+      },
+    };
+  },
+};

packages/kbn-eslint-plugin-eslint/rules/scout_no_deprecated_tags.test.js

@@ -0,0 +1,104 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+const { RuleTester } = require('eslint');
+const rule = require('./scout_no_deprecated_tags');
+const dedent = require('dedent');
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('@typescript-eslint/parser'),
+  parserOptions: {
+    sourceType: 'module',
+    ecmaVersion: 2018,
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+});
+
+ruleTester.run('@kbn/eslint/scout_no_deprecated_tags', rule, {
+  valid: [
+    {
+      code: dedent`
+        test.describe('my test suite', () => {
+          test('should work', () => {
+            expect(true).toBe(true);
+          });
+        });
+      `,
+    },
+    {
+      code: dedent`
+        import { tags } from '@kbn/scout';
+        test.describe('my test suite', { tag: [...tags.stateful.classic, ...tags.serverless.observability.complete] }, () => {
+          test('should work', () => {
+            expect(true).toBe(true);
+          });
+        });
+      `,
+    },
+    {
+      code: dedent`
+        import { tags } from '@kbn/scout-oblt';
+        apiTest.describe('API test', { tag: [...tags.stateful.classic] }, () => {
+          apiTest('should work', () => {});
+        });
+      `,
+    },
+    {
+      code: dedent`
+        spaceTest.describe('space test', { tag: tags.stateful.classic }, () => {
+          spaceTest('should work', () => {});
+        });
+      `,
+    },
+    {
+      code: dedent`
+        test.describe('my test suite', { tag: ['@perf'] }, () => {
+          test('should work', () => {});
+        });
+      `,
+    },
+  ],
+
+  invalid: [
+    {
+      code: dedent`
+        test.describe('my test suite', { tag: ['@ess'] }, () => {
+          test('should work', () => {});
+        });
+      `,
+      errors: [{ messageId: 'deprecatedTag' }],
+    },
+    {
+      code: dedent`
+        test.describe('my test suite', { tag: ['@ess', '@svlOblt'] }, () => {
+          test('should work', () => {});
+        });
+      `,
+      errors: [{ messageId: 'deprecatedTag' }],
+    },
+    {
+      code: dedent`
+        apiTest.describe('API test', { tag: ['@svlSecurity', '@svlSearch'] }, () => {
+          apiTest('should work', () => {});
+        });
+      `,
+      errors: [{ messageId: 'deprecatedTag' }],
+    },
+    {
+      code: dedent`
+        spaceTest.describe('space test', { tag: ['@ess', '@svlOblt', '@svlSecurity'] }, () => {
+          spaceTest('should work', () => {});
+        });
+      `,
+      errors: [{ messageId: 'deprecatedTag' }],
+    },
+  ],
+});

packages/kbn-eslint-plugin-eslint/rules/scout_test_file_naming.js

@@ -150,7 +150,7 @@ module.exports = {
       // File is in /test/scout but not in the correct subdirectory structure
       // Only report if it looks like a test file (has test/spec in name or is .ts)
       const basename = path.basename(filename, '.ts');
-      if (basename.includes('test') || basename.includes('spec') || hasSpecExtension(filename)) {
+      if (basename.includes('spec') || hasSpecExtension(filename)) {
         return {
           Program(node) {
             context.report({

packages/kbn-eslint-plugin-eslint/rules/scout_test_file_naming.test.js

@@ -74,6 +74,12 @@ ruleTester.run('@kbn/eslint/scout_test_file_naming', rule, {
       code: '',
       filename: 'x-pack/solutions/observability/plugins/my_plugin/test/scout/common/constants.ts',
     },
+    // Valid: Scout fixture file with 'test' in the name (not a test file)
+    {
+      code: '',
+      filename:
+        'x-pack/platform/packages/shared/kbn-streamlang-tests/test/scout/api/fixtures/test_bed_fixture.ts',
+    },
     // Valid: Scout config file
     {
       code: '',