Skip to content

Commit b92a9ab

Browse files
authored
[ML] [Data Frame Analytics] Fixing Job details fly-out in Analytics Map page (elastic#236131)
## Summary Fixes elastic#235819 Analytics Map page was missing provider and job details fly-out component. That was causing `JobInfoFlyoutsContext` to fallback to default values and it never reached a point where the Job Details Flyout is properly displayed. #### Recording with fix: https://github.com/user-attachments/assets/d2accf62-7c34-4430-bcd5-82768ee502d6 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
1 parent 759649f commit b92a9ab

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

  • x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/job_map

x-pack/platform/plugins/shared/ml/public/application/data_frame_analytics/pages/job_map/page.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ import type { AnalyticsSelectorIds } from '../components/analytics_selector';
2323
import { AnalyticsIdSelector, AnalyticsIdSelectorControls } from '../components/analytics_selector';
2424
import { AnalyticsEmptyPrompt } from '../analytics_management/components/empty_prompt';
2525
import { PageTitle } from '../../../components/page_title';
26+
import { JobInfoFlyoutsProvider } from '../../../jobs/components/job_details_flyout/job_details_flyout_context';
27+
import { AnalyticsDetailFlyout } from '../analytics_exploration/components/analytics_detail_flyout';
2628

2729
export const Page: FC = () => {
2830
const [globalState, setGlobalState] = useUrlState('_g');
@@ -102,7 +104,8 @@ export const Page: FC = () => {
102104
};
103105

104106
return (
105-
<>
107+
<JobInfoFlyoutsProvider>
108+
<AnalyticsDetailFlyout />
106109
<AnalyticsIdSelectorControls
107110
setIsIdSelectorFlyoutVisible={setIsIdSelectorFlyoutVisible}
108111
selectedId={jobId ?? modelId}
@@ -171,6 +174,6 @@ export const Page: FC = () => {
171174
getEmptyState()
172175
)}
173176
<HelpMenu docLink={helpLink} />
174-
</>
177+
</JobInfoFlyoutsProvider>
175178
);
176179
};

0 commit comments

Comments
 (0)