Skip to content

Commit cd8254b

Browse files
paulinashakirovaeokoneyokibanamachinealexwizpsemd
authored
[SharedUX] SCSS migration kibana_overview plugin (elastic#215942)
## Summary This PR is a part of SCSS migration of SharedUX team code. Here is a [meta](elastic/kibana-team#1417) issue for it. --------- Co-authored-by: Eyo O. Eyo <7893459+eokoneyo@users.noreply.github.com> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent ac97356 commit cd8254b

8 files changed

Lines changed: 129 additions & 133 deletions

File tree

src/platform/plugins/private/kibana_overview/public/components/manage_data/__snapshots__/manage_data.test.tsx.snap

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/private/kibana_overview/public/components/manage_data/manage_data.tsx

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,16 @@
99

1010
import React, { FC } from 'react';
1111
import PropTypes from 'prop-types';
12-
import { EuiFlexGroup, EuiFlexItem, EuiHorizontalRule, EuiSpacer, EuiTitle } from '@elastic/eui';
12+
import { css } from '@emotion/react';
13+
import {
14+
EuiFlexGroup,
15+
EuiFlexItem,
16+
EuiHorizontalRule,
17+
EuiSpacer,
18+
EuiTitle,
19+
UseEuiTheme,
20+
useEuiMinBreakpoint,
21+
} from '@elastic/eui';
1322
import { FormattedMessage } from '@kbn/i18n-react';
1423
import { CoreStart } from '@kbn/core/public';
1524
import { useKibana } from '@kbn/kibana-react-plugin/public';
@@ -27,6 +36,7 @@ export const ManageData: FC<Props> = ({ addBasePath, features }) => {
2736
const {
2837
services: { application },
2938
} = useKibana<CoreStart>();
39+
const minBreakpointM = useEuiMinBreakpoint('m');
3040
return (
3141
<>
3242
{features.length > 1 ? <EuiHorizontalRule margin="xl" aria-hidden="true" /> : null}
@@ -47,9 +57,20 @@ export const ManageData: FC<Props> = ({ addBasePath, features }) => {
4757

4858
<EuiSpacer size="m" />
4959

50-
<EuiFlexGroup className="kbnOverviewDataManage__content" wrap>
60+
<EuiFlexGroup wrap>
5161
{features.map((feature) => (
52-
<EuiFlexItem className="kbnOverviewDataManage__item" key={feature.id}>
62+
<EuiFlexItem
63+
key={feature.id}
64+
css={({ euiTheme }: UseEuiTheme) =>
65+
css({
66+
':not(:only-child)': {
67+
[minBreakpointM]: {
68+
flex: `0 0 calc(50% - ${euiTheme.size.l})`,
69+
},
70+
},
71+
})
72+
}
73+
>
5374
<RedirectAppLinks
5475
coreStart={{
5576
application,

src/platform/plugins/private/kibana_overview/public/components/news_feed/__snapshots__/news_feed.test.tsx.snap

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/platform/plugins/private/kibana_overview/public/components/news_feed/news_feed.tsx

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,42 @@
88
*/
99

1010
import React, { FC } from 'react';
11-
import { EuiLink, EuiSpacer, EuiText, EuiTitle } from '@elastic/eui';
11+
import { EuiLink, EuiSpacer, EuiText, EuiTitle, UseEuiTheme } from '@elastic/eui';
12+
import { css } from '@emotion/react';
1213
import { FormattedMessage } from '@kbn/i18n-react';
1314
import { FetchResult } from '@kbn/newsfeed-plugin/public';
1415

1516
interface Props {
16-
newsFetchResult: FetchResult;
17+
newsFetchResult: FetchResult | null | void;
1718
}
19+
const styles = ({ euiTheme }: UseEuiTheme) =>
20+
css({
21+
article: {
22+
'& + article': {
23+
marginTop: euiTheme.size.l,
24+
},
25+
'&, header': {
26+
'& > * + *': {
27+
marginTop: euiTheme.size.xs,
28+
},
29+
},
30+
h3: {
31+
fontWeight: 'inherit',
32+
},
33+
},
34+
});
1835

1936
export const NewsFeed: FC<Props> = ({ newsFetchResult }) => (
20-
<section aria-labelledby="kbnOverviewNews__title" className="kbnOverviewNews">
37+
<section aria-labelledby="kbnOverviewNews__title">
2138
<EuiTitle size="s">
2239
<h2 id="kbnOverviewNews__title">
2340
<FormattedMessage id="kibanaOverview.news.title" defaultMessage="What's new" />
2441
</h2>
2542
</EuiTitle>
2643

2744
<EuiSpacer size="m" />
28-
29-
<div className="kbnOverviewNews__content">
30-
{newsFetchResult.feedItems
45+
<div css={styles}>
46+
{newsFetchResult?.feedItems
3147
.slice(0, 3)
3248
.map(({ title, description, linkUrl, publishOn }, index) => (
3349
<article key={title} aria-labelledby={`kbnOverviewNews__title${index}`}>

src/platform/plugins/private/kibana_overview/public/components/overview/overview.scss

Lines changed: 0 additions & 84 deletions
This file was deleted.

0 commit comments

Comments
 (0)