Skip to content

Commit de4899e

Browse files
authored
[Security Solution] Remove integration card dependency for connector card (elastic#227060)
## Summary elastic#226162 Remove the dependency of integration card for connectors set up card according to this [discussion](https://elastic.slack.com/archives/C08D26QFR18/p1751623558608069?thread_ts=1751043593.700079&cid=C08D26QFR18), so it won't have this view anymore. ![Image](https://github.com/user-attachments/assets/1a8b3e5b-d39a-412a-a352-e373377e3503) - When Elastic LLM is available: <img width="2091" alt="Screenshot 2025-07-08 at 16 00 51" src="https://github.com/user-attachments/assets/752bc336-6c5a-4a4d-8036-5bba5bc85334" /> - When Elastic LLM is `Not` available: <img width="1300" alt="Screenshot 2025-07-08 at 16 02 12" src="https://github.com/user-attachments/assets/da5e657e-0984-4888-a4e3-67935ae18605" />
1 parent 126b267 commit de4899e

5 files changed

Lines changed: 8 additions & 69 deletions

File tree

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39396,8 +39396,6 @@
3939639396
"xpack.securitySolution.onboarding.alertsCards.timeline.title": "Investiguer dans la chronologie",
3939739397
"xpack.securitySolution.onboarding.alertsGroup.title": "Configurer les règles et les alertes",
3939839398
"xpack.securitySolution.onboarding.assistantCard.badge.completeText": "{count} {count, plural, one {connector} other {connecteurs IA ajoutés}}",
39399-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsButton": "Ajouter des étapes d'intégration",
39400-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsText": "Pour ajouter des règles Elastic, ajoutez d'abord des intégrations.",
3940139399
"xpack.securitySolution.onboarding.assistantCard.createNewConnectorPopover": "Fournisseur de service d'IA",
3940239400
"xpack.securitySolution.onboarding.assistantCard.description": "Choisissez et configurez n'importe quel fournisseur d'IA disponible pour l'utiliser avec Elastic AI Assistant.",
3940339401
"xpack.securitySolution.onboarding.assistantCard.missingPrivileges.contactAdministrator": "Contactez votre administrateur si vous avez besoin d'aide.",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39442,8 +39442,6 @@
3944239442
"xpack.securitySolution.onboarding.alertsCards.timeline.title": "タイムラインで調査",
3944339443
"xpack.securitySolution.onboarding.alertsGroup.title": "ルールとアラートを構成",
3944439444
"xpack.securitySolution.onboarding.assistantCard.badge.completeText": "{count}個のAI {count, plural, one {connector} other {コネクター}}が追加されました",
39445-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsButton": "統合ステップの追加",
39446-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsText": "Elasticルールを追加するには、最初に統合を追加してください。",
3944739445
"xpack.securitySolution.onboarding.assistantCard.createNewConnectorPopover": "AIサービスプロバイダー",
3944839446
"xpack.securitySolution.onboarding.assistantCard.description": "Elastic AI Assistantで使用できるAIプロバイダーを選択し、構成します。",
3944939447
"xpack.securitySolution.onboarding.assistantCard.missingPrivileges.contactAdministrator": "サポートについては、管理者にお問い合わせください。",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39421,8 +39421,6 @@
3942139421
"xpack.securitySolution.onboarding.alertsCards.timeline.title": "在时间线中调查",
3942239422
"xpack.securitySolution.onboarding.alertsGroup.title": "配置规则和告警",
3942339423
"xpack.securitySolution.onboarding.assistantCard.badge.completeText": "{count} 个 AI {count, plural, one {连接器} other {连接器}}已添加",
39424-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsButton": "添加集成步骤",
39425-
"xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsText": "要添加 Elastic 规则,请先添加集成。",
3942639424
"xpack.securitySolution.onboarding.assistantCard.createNewConnectorPopover": "AI 服务提供商",
3942739425
"xpack.securitySolution.onboarding.assistantCard.description": "选择并配置可与 Elastic AI 助手搭配使用的任何 AI 提供商。",
3942839426
"xpack.securitySolution.onboarding.assistantCard.missingPrivileges.contactAdministrator": "请联系管理员寻求帮助。",

x-pack/solutions/security/plugins/security_solution/public/onboarding/components/onboarding_body/cards/assistant/assistant_card.tsx

Lines changed: 8 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@
66
*/
77

88
import React, { useCallback, useMemo } from 'react';
9-
import { EuiFlexGroup, EuiFlexItem, EuiIcon, EuiLink } from '@elastic/eui';
10-
import { css } from '@emotion/css';
9+
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
1110
import {
1211
useAssistantContext,
1312
type Conversation,
@@ -23,15 +22,13 @@ import {
2322
import { useConversation } from '@kbn/elastic-assistant/impl/assistant/use_conversation';
2423

2524
import { CenteredLoadingSpinner } from '../../../../../common/components/centered_loading_spinner';
26-
import { OnboardingCardId } from '../../../../constants';
2725
import type { OnboardingCardComponent } from '../../../../types';
2826
import * as i18n from './translations';
2927
import { ConnectorsMissingPrivilegesCallOut } from '../common/connectors/missing_privileges';
3028
import { useStoredAssistantConnectorId } from '../../../hooks/use_stored_state';
3129
import { useOnboardingContext } from '../../../onboarding_context';
3230
import { OnboardingCardContentPanel } from '../common/card_content_panel';
3331
import { ConnectorCards } from '../common/connectors/connector_cards';
34-
import { CardCallOut } from '../common/card_callout';
3532
import { CardSubduedText } from '../common/card_subdued_text';
3633
import type { AIConnector } from '../common/connectors/types';
3734
import type { AssistantCardMetadata } from './types';
@@ -47,20 +44,6 @@ export const AssistantCard: OnboardingCardComponent<AssistantCardMetadata> = ({
4744
const { spaceId } = useOnboardingContext();
4845
const { connectors, canExecuteConnectors, canCreateConnectors } = checkCompleteMetadata ?? {};
4946

50-
const isIntegrationsCardComplete = useMemo(
51-
() => isCardComplete(OnboardingCardId.integrations),
52-
[isCardComplete]
53-
);
54-
55-
const isIntegrationsCardAvailable = useMemo(
56-
() => isCardAvailable(OnboardingCardId.integrations),
57-
[isCardAvailable]
58-
);
59-
60-
const expandIntegrationsCard = useCallback(() => {
61-
setExpandedCardId(OnboardingCardId.integrations, { scroll: true });
62-
}, [setExpandedCardId]);
63-
6447
const [selectedConnectorId, setSelectedConnectorId] = useStoredAssistantConnectorId(spaceId);
6548

6649
const defaultConnector = useMemo(() => getDefaultConnector(connectors), [connectors]);
@@ -172,37 +155,13 @@ export const AssistantCard: OnboardingCardComponent<AssistantCardMetadata> = ({
172155
</CardSubduedText>
173156
</EuiFlexItem>
174157
<EuiFlexItem>
175-
{isIntegrationsCardAvailable && !isIntegrationsCardComplete ? (
176-
<EuiFlexItem
177-
className={css`
178-
width: 45%;
179-
`}
180-
>
181-
<CardCallOut
182-
color="primary"
183-
icon="info"
184-
text={i18n.ASSISTANT_CARD_CALLOUT_INTEGRATIONS_TEXT}
185-
action={
186-
<EuiLink onClick={expandIntegrationsCard}>
187-
<EuiFlexGroup direction="row" gutterSize="xs" alignItems="center">
188-
<EuiFlexItem>{i18n.ASSISTANT_CARD_CALLOUT_INTEGRATIONS_BUTTON}</EuiFlexItem>
189-
<EuiFlexItem grow={false}>
190-
<EuiIcon type="arrowRight" color="primary" size="s" />
191-
</EuiFlexItem>
192-
</EuiFlexGroup>
193-
</EuiLink>
194-
}
195-
/>
196-
</EuiFlexItem>
197-
) : (
198-
<ConnectorCards
199-
canCreateConnectors={canCreateConnectors}
200-
connectors={connectors}
201-
onNewConnectorSaved={onNewConnectorSaved}
202-
selectedConnectorId={selectedConnectorId}
203-
onConnectorSelected={onConnectorSelected}
204-
/>
205-
)}
158+
<ConnectorCards
159+
canCreateConnectors={canCreateConnectors}
160+
connectors={connectors}
161+
onNewConnectorSaved={onNewConnectorSaved}
162+
selectedConnectorId={selectedConnectorId}
163+
onConnectorSelected={onConnectorSelected}
164+
/>
206165
</EuiFlexItem>
207166
</EuiFlexGroup>
208167
) : (

x-pack/solutions/security/plugins/security_solution/public/onboarding/components/onboarding_body/cards/assistant/translations.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,3 @@ export const ASSISTANT_CARD_DESCRIPTION = i18n.translate(
2020
'Choose and configure any AI provider available to use with Elastic AI Assistant.',
2121
}
2222
);
23-
24-
export const ASSISTANT_CARD_CALLOUT_INTEGRATIONS_TEXT = i18n.translate(
25-
'xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsText',
26-
{
27-
defaultMessage: 'To add Elastic rules add integrations first.',
28-
}
29-
);
30-
31-
export const ASSISTANT_CARD_CALLOUT_INTEGRATIONS_BUTTON = i18n.translate(
32-
'xpack.securitySolution.onboarding.assistantCard.calloutIntegrationsButton',
33-
{
34-
defaultMessage: 'Add integrations step',
35-
}
36-
);

0 commit comments

Comments
 (0)