[Lens as code] Align public API meta with dashboard APIs (elastic#260846)

## Summary

Follows changes in elastic#260789

Changes:
- Cleans up public route `meta` schema and types to use the shared
versions.
- Remove generic typings for extra `meta` properties.
- Removes saved object client error checking. This is not needed for the
methods we use, mainly just `/bulk`.
- Internal routes still pass Lens-specific `meta` properties but this
can be cleaned later.
- Content Management still returns camelCased meta, this can be changed
when internal routes are removed.

Closes elastic#260792

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Author: nickofthyme

src/platform/packages/shared/as-code/shared-schemas/index.ts

@@ -7,4 +7,4 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { asCodeIdSchema, asCodeMetaSchema, getMeta } from './src/schemas';
+export { asCodeIdSchema, asCodeMetaSchema, getMeta, type AsCodeMeta } from './src/schemas';

src/platform/packages/shared/as-code/shared-schemas/src/schemas/index.ts

@@ -8,4 +8,4 @@
  */
 
 export { asCodeIdSchema } from './id';
-export { asCodeMetaSchema, getMeta } from './meta';
+export { asCodeMetaSchema, getMeta, type AsCodeMeta } from './meta';

src/platform/packages/shared/as-code/shared-schemas/src/schemas/meta/index.ts

@@ -8,4 +8,4 @@
  */
 
 export { getMeta } from './get_meta';
-export { asCodeMetaSchema } from './schema';
+export { asCodeMetaSchema, type AsCodeMeta } from './schema';

x-pack/platform/plugins/shared/lens/moon.yml

@@ -151,6 +151,7 @@ dependsOn:
   - '@kbn/field-formats-common'
   - '@kbn/calculate-auto'
   - '@kbn/esql-language'
+  - '@kbn/as-code-shared-schemas'
   - '@kbn/core-http-browser'
 tags:
   - plugin

x-pack/platform/plugins/shared/lens/public/persistence/lens_client.ts

@@ -32,6 +32,7 @@ import { getLensBuilder } from '../lazy_builder';
 
 export interface LensItemResponse<M extends Record<string, string | boolean> = {}> {
   item: LensItem;
+  // TODO: align meta with public routes when internal routes are removed
   meta: LensItemMeta & M;
 }
 

x-pack/platform/plugins/shared/lens/server/api/routes/visualizations/create.ts

@@ -17,7 +17,8 @@ import {
   LENS_API_TAG,
 } from '../../../../common/constants';
 import type { LensCreateIn, LensSavedObject } from '../../../content_management';
-import type { LensCreateResponseBody, RegisterAPIRouteFn } from '../../../types';
+import type { RegisterAPIRouteFn } from '../../types';
+import type { LensCreateResponseBody } from './types';
 import { getLensRequestConfig, getLensResponseItem } from './utils';
 import {
   lensCreateRequestBodySchema,
@@ -95,12 +96,8 @@ export const registerLensVisualizationsCreateAPIRoute: RegisterAPIRouteFn = (
         const { references, ...data } = getLensRequestConfig(builder, req.body);
         const options: LensCreateIn['options'] = { ...req.query, references };
         const { result } = await client.create(data, options);
-
-        if (result.item.error) {
-          throw result.item.error;
-        }
-
         const responseItem = getLensResponseItem(builder, result.item);
+
         return res.created<LensCreateResponseBody>({
           body: responseItem,
         });

x-pack/platform/plugins/shared/lens/server/api/routes/visualizations/get.ts

@@ -82,11 +82,6 @@ export const registerLensVisualizationsGetAPIRoute: RegisterAPIRouteFn = (
 
       try {
         const { result } = await client.get(req.params.id);
-
-        if (result.item.error) {
-          throw result.item.error;
-        }
-
         const responseItem = getLensResponseItem(builder, result.item);
 
         return res.ok<TypeOf<typeof lensGetResponseBodySchema>>({

x-pack/platform/plugins/shared/lens/server/api/routes/visualizations/schema/common.ts

@@ -7,35 +7,20 @@
 
 import { schema } from '@kbn/config-schema';
 import { lensApiStateSchema } from '@kbn/lens-embeddable-utils';
+import { asCodeMetaSchema } from '@kbn/as-code-shared-schemas';
 
 import { lensCommonSavedObjectSchemaV2 } from '../../../../content_management';
 
 const savedObjectProps = lensCommonSavedObjectSchemaV2.getPropSchemas();
 
-/**
- * The Lens item meta returned from the server
- */
-export const lensItemMetaSchema = schema.object(
-  {
-    type: savedObjectProps.type,
-    created_at: savedObjectProps.createdAt,
-    updated_at: savedObjectProps.updatedAt,
-    created_by: savedObjectProps.createdBy,
-    updated_by: savedObjectProps.updatedBy,
-    origin_id: savedObjectProps.originId,
-    managed: savedObjectProps.managed,
-  },
-  { unknowns: 'forbid', meta: { id: 'lensItemMeta', title: 'Visualization Meta' } }
-);
-
 /**
  * The Lens response item returned from the server
  */
 export const lensResponseItemSchema = schema.object(
   {
     id: savedObjectProps.id,
     data: lensApiStateSchema,
-    meta: lensItemMetaSchema,
+    meta: asCodeMetaSchema,
   },
   { unknowns: 'forbid', meta: { id: 'lensResponseItem', title: 'Visualization Response' } }
 );

x-pack/platform/plugins/shared/lens/server/api/routes/visualizations/types.ts

@@ -22,9 +22,8 @@ import type {
   lensUpdateRequestParamsSchema,
   lensUpdateResponseBodySchema,
 } from './schema';
-import type { lensItemMetaSchema, lensResponseItemSchema } from './schema/common';
+import type { lensResponseItemSchema } from './schema/common';
 
-export type LensItemMeta = TypeOf<typeof lensItemMetaSchema>;
 export type LensResponseItem = TypeOf<typeof lensResponseItemSchema>;
 
 export type LensCreateRequestQuery = TypeOf<typeof lensCreateRequestQuerySchema>;

x-pack/platform/plugins/shared/lens/server/api/routes/visualizations/update.ts

@@ -20,7 +20,9 @@ import {
   LENS_API_TAG,
 } from '../../../../common/constants';
 import type { LensUpdateIn, LensSavedObject } from '../../../content_management';
-import type { LensUpdateResponseBody, RegisterAPIRouteFn } from '../../../types';
+
+import type { RegisterAPIRouteFn } from '../../types';
+import type { LensUpdateResponseBody } from './types';
 import {
   lensUpdateRequestBodySchema,
   lensUpdateRequestParamsSchema,
@@ -119,11 +121,6 @@ export const registerLensVisualizationsUpdateAPIRoute: RegisterAPIRouteFn = (
 
       try {
         const { result } = await client.update(req.params.id, data, options);
-
-        if (result.item.error) {
-          throw result.item.error;
-        }
-
         const responseItem = getLensResponseItem(builder, result.item);
 
         if (createdNew) {