From ccee1cb1f5c29994611e6e677bece1ceb7ce38ed Mon Sep 17 00:00:00 2001 From: Stu Hood Date: Fri, 27 Jun 2025 09:15:40 -0700 Subject: [PATCH] Use if-let to unpack an option, to avoid tripping the `for_loops_over_fallibles` warning in Rust `1.88.0`. --- pgrx-macros/src/lib.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pgrx-macros/src/lib.rs b/pgrx-macros/src/lib.rs index 37c70bdfcc..b070451806 100644 --- a/pgrx-macros/src/lib.rs +++ b/pgrx-macros/src/lib.rs @@ -967,7 +967,7 @@ fn impl_postgres_type(ast: DeriveInput) -> syn::Result #[::pgrx::pgrx_macros::pg_extern(immutable,parallel_safe)] pub fn #funcname_in #generics(input: Option<&::core::ffi::CStr>) -> Option<#name #generics> { input.map_or_else(|| { - for m in <#name as ::pgrx::inoutfuncs::InOutFuncs>::NULL_ERROR_MESSAGE { + if let Some(m) = <#name as ::pgrx::inoutfuncs::InOutFuncs>::NULL_ERROR_MESSAGE { ::pgrx::pg_sys::error!("{m}"); } None @@ -990,7 +990,7 @@ fn impl_postgres_type(ast: DeriveInput) -> syn::Result #[::pgrx::pgrx_macros::pg_extern(immutable,parallel_safe)] pub fn #funcname_in #generics(input: Option<&::core::ffi::CStr>) -> Option<::pgrx::datum::PgVarlena<#name #generics>> { input.map_or_else(|| { - for m in <#name as ::pgrx::inoutfuncs::PgVarlenaInOutFuncs>::NULL_ERROR_MESSAGE { + if let Some(m) = <#name as ::pgrx::inoutfuncs::PgVarlenaInOutFuncs>::NULL_ERROR_MESSAGE { ::pgrx::pg_sys::error!("{m}"); } None