Skip to content

Commit 824c769

Browse files
committed
Don't try to do feedback on sessions without start time
These sessions aren't listed in the session list or schedule, but if they are linked to externally we would allow them and then crash later when checking the starttime. So instead of crashing, just disallow the feedback form on sessions that shouldn't have it.
1 parent 6d4562b commit 824c769

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

postgresqleu/confreg/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1134,7 +1134,7 @@ def feedback(request, confname):
11341134
def feedback_session(request, confname, sessionid):
11351135
# Room for optimization: don't get these as separate steps
11361136
conference = get_conference_or_404(confname)
1137-
session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1)
1137+
session = get_object_or_404(ConferenceSession, pk=sessionid, conference=conference, status=1, can_feedback=True, starttime__isnull=False)
11381138

11391139
if not conference.feedbackopen:
11401140
# Allow conference testers to override

0 commit comments

Comments
 (0)