GitHub disallows secrets in job-level if expressions

Author: pglombardo

.github/workflows/campfire-notify.yml

@@ -11,8 +11,18 @@ jobs:
   post-commit-info:
     runs-on: ubuntu-latest
     steps:
+      - id: campfire-configured
+        env:
+          CAMPFIRE_MESSAGES_URL: ${{ secrets.CAMPFIRE_MESSAGES_URL }}
+        run: |
+          if [ -n "${CAMPFIRE_MESSAGES_URL}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Post commit info to Campfire
-        if: secrets.CAMPFIRE_MESSAGES_URL != ''
+        if: steps.campfire-configured.outputs.configured == 'true'
         continue-on-error: true
         uses: shane-lamb/campfire-notify-action@df63cf73810147306276e281bedccf71c1519caf # v1.1.6
         with:

.github/workflows/docker-containers.yml

@@ -47,6 +47,16 @@ jobs:
     if: needs.docker-configured.outputs.enabled == 'true' && ((github.event.label && github.event.label.name == 'docker') || github.event_name != 'pull_request')
     runs-on: ubuntu-latest
     steps:
+      - id: campfire-configured
+        env:
+          CAMPFIRE_MESSAGES_URL: ${{ secrets.CAMPFIRE_MESSAGES_URL }}
+        run: |
+          if [ -n "${CAMPFIRE_MESSAGES_URL}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Checkout
         uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
         with:
@@ -95,7 +105,7 @@ jobs:
             type=gha,mode=max
 
       - name: Post job failure details to Campfire
-        if: failure() && secrets.CAMPFIRE_MESSAGES_URL != '' && github.ref == 'refs/heads/master'
+        if: failure() && steps.campfire-configured.outputs.configured == 'true' && github.ref == 'refs/heads/master'
         continue-on-error: true
         uses: shane-lamb/campfire-notify-action@df63cf73810147306276e281bedccf71c1519caf # v1.1.6
         with:
@@ -108,6 +118,16 @@ jobs:
     if: needs.docker-configured.outputs.enabled == 'true' && ((github.event.label && github.event.label.name == 'docker') || github.event_name != 'pull_request')
     runs-on: ubuntu-latest
     steps:
+      - id: campfire-configured
+        env:
+          CAMPFIRE_MESSAGES_URL: ${{ secrets.CAMPFIRE_MESSAGES_URL }}
+        run: |
+          if [ -n "${CAMPFIRE_MESSAGES_URL}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Checkout
         uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
         with:
@@ -161,7 +181,7 @@ jobs:
             type=gha,mode=max
 
       - name: Post job failure details to Campfire
-        if: failure() && secrets.CAMPFIRE_MESSAGES_URL != '' && github.ref == 'refs/heads/master'
+        if: failure() && steps.campfire-configured.outputs.configured == 'true' && github.ref == 'refs/heads/master'
         continue-on-error: true
         uses: shane-lamb/campfire-notify-action@df63cf73810147306276e281bedccf71c1519caf # v1.1.6
         with:
@@ -173,6 +193,16 @@ jobs:
     if: needs.docker-configured.outputs.enabled == 'true' && ((github.event.label && github.event.label.name == 'docker') || github.event_name != 'pull_request')
     runs-on: ubuntu-latest
     steps:
+      - id: campfire-configured
+        env:
+          CAMPFIRE_MESSAGES_URL: ${{ secrets.CAMPFIRE_MESSAGES_URL }}
+        run: |
+          if [ -n "${CAMPFIRE_MESSAGES_URL}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Checkout
         uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
         with:
@@ -226,7 +256,7 @@ jobs:
             type=gha,mode=max
 
       - name: Post job failure details to Campfire
-        if: failure() && secrets.CAMPFIRE_MESSAGES_URL != '' && github.ref == 'refs/heads/master'
+        if: failure() && steps.campfire-configured.outputs.configured == 'true' && github.ref == 'refs/heads/master'
         continue-on-error: true
         uses: shane-lamb/campfire-notify-action@df63cf73810147306276e281bedccf71c1519caf # v1.1.6
         with:

.github/workflows/hatchbox-deploy.yml

@@ -12,8 +12,18 @@ jobs:
   deploy:
     runs-on: ubuntu-latest
     steps:
+      - id: hatchbox-configured
+        env:
+          HATCHBOX_DEPLOY_KEY: ${{ secrets.HATCHBOX_DEPLOY_KEY }}
+        run: |
+          if [ -n "${HATCHBOX_DEPLOY_KEY}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Deploy to Hatchbox
-        if: secrets.HATCHBOX_DEPLOY_KEY != ''
+        if: steps.hatchbox-configured.outputs.configured == 'true'
         uses: hatchboxio/github-hatchbox-deploy-action@3bbadafe51e89bbf29fd3932bd84534f4fc9a00c # v2
         with:
           deploy_key: ${{ secrets.HATCHBOX_DEPLOY_KEY }}

.github/workflows/lint-helm.yaml

@@ -11,6 +11,16 @@ jobs:
     env:
       TARGET_BRANCH: ${{ github.event.repository.default_branch }}
     steps:
+      - id: campfire-configured
+        env:
+          CAMPFIRE_MESSAGES_URL: ${{ secrets.CAMPFIRE_MESSAGES_URL }}
+        run: |
+          if [ -n "${CAMPFIRE_MESSAGES_URL}" ]; then
+            echo "configured=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "configured=false" >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Checkout
         uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
         with:
@@ -51,7 +61,7 @@ jobs:
         run: ct install --config ./ct.yaml --target-branch "$TARGET_BRANCH"
 
       - name: Post job failure details to Campfire
-        if: failure() && secrets.CAMPFIRE_MESSAGES_URL != '' && github.base_ref == env.TARGET_BRANCH
+        if: failure() && steps.campfire-configured.outputs.configured == 'true' && github.base_ref == env.TARGET_BRANCH
         continue-on-error: true
         uses: shane-lamb/campfire-notify-action@df63cf73810147306276e281bedccf71c1519caf # v1.1.6
         with: