Address Copilot review feedback on notify-by-email errors.

Use literal gettext calls in human_attribute_name so strings are extractable, and reword owner-only validation to "allowed only for owners."

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Peter Giacomo Lombardo

app/models/concerns/pwpush/notifiable_by_email.rb

@@ -5,11 +5,6 @@ module NotifiableByEmail
     extend ActiveSupport::Concern
     MAX_NOTIFY_BY_EMAILS = 5
 
-    NOTIFY_BY_EMAIL_HUMAN_ATTRIBUTE_NAMES = {
-      notify_emails_to: "Recipient emails",
-      notify_emails_to_locale: "Notification language"
-    }.freeze
-
     included do
       attr_accessor :notify_emails_to, :notify_emails_to_locale, :notify_emails_to_required, :notify_by_email_creator, :notify_by_email_skip_limit_validation, :notify_by_email_recipients, :notify_by_email_locale
 
@@ -34,8 +29,14 @@ def notify_by_email_available?
 
     class_methods do
       def human_attribute_name(attribute, options = {})
-        name = NOTIFY_BY_EMAIL_HUMAN_ATTRIBUTE_NAMES[attribute.to_sym]
-        name ? _(name) : super
+        case attribute.to_sym
+        when :notify_emails_to
+          _("Recipient emails")
+        when :notify_emails_to_locale
+          _("Notification language")
+        else
+          super
+        end
       end
     end
 
@@ -74,8 +75,8 @@ def validate_notify_by_email_availability
       end
 
       unless notify_by_email_creator == user
-        errors.add(:notify_emails_to, _("are allowed for only owners")) if notify_emails_to.present?
-        errors.add(:notify_emails_to_locale, _("is allowed for only owners")) if notify_emails_to_locale.present?
+        errors.add(:notify_emails_to, _("are allowed only for owners")) if notify_emails_to.present?
+        errors.add(:notify_emails_to_locale, _("is allowed only for owners")) if notify_emails_to_locale.present?
 
         return
       end

test/models/concerns/pwpush/notifiable_by_email_test.rb

@@ -85,8 +85,8 @@ class Pwpush::NotifiableByEmailTest < ActiveSupport::TestCase
 
     assert @other_user != @user
     assert_not @push.valid?
-    assert_includes @push.errors[:notify_emails_to], "are allowed for only owners"
-    assert_includes @push.errors[:notify_emails_to_locale], "is allowed for only owners"
+    assert_includes @push.errors[:notify_emails_to], "are allowed only for owners"
+    assert_includes @push.errors[:notify_emails_to_locale], "is allowed only for owners"
   end
 
   # Test notify_by_email_limit validation