Update an event used to create notify_by_email

Author: ozovalihasan

app/controllers/concerns/log_events.rb

@@ -27,11 +27,13 @@ def log_creation_email_send(push)
     return unless push.notify_by_email_recipients.present?
 
     ip, user_agent, referrer = log_info
-    audit_log = push.audit_logs.create!(kind: :creation_email_send, user: current_user, ip:, user_agent:, referrer:)
+    audit_log = push.audit_logs.build(kind: :creation_email_send, user: current_user, ip:, user_agent:, referrer:)
 
     recipients = push.notify_by_email_recipients
     locale = push.notify_by_email_locale
-    notify_by_email = audit_log.create_notify_by_email!(recipients: recipients, locale: locale)
+    notify_by_email = audit_log.build_notify_by_email(recipients: recipients, locale: locale)
+
+    audit_log.save!
 
     SendPushCreatedEmailJob.perform_later(notify_by_email.id)
   end

test/controllers/concerns/log_events_test.rb

@@ -10,6 +10,7 @@ class LogEventsTestController < ApplicationController
 class LogEventsTest < ActionController::TestCase
   tests LogEventsTestController
   include Devise::Test::ControllerHelpers
+  include ActiveJob::TestHelper
 
   setup do
     @push = pushes(:test_push)
@@ -161,6 +162,65 @@ class LogEventsTest < ActionController::TestCase
     assert_not_equal @push, log.push
   end
 
+  test "log_creation_email_send creates an audit_log and notify_by_email" do
+    @request.env["REMOTE_ADDR"] = "172.16.0.1"
+    @request.env["HTTP_USER_AGENT"] = "TestAgent/1.0"
+    @request.env["HTTP_REFERER"] = "https://test.com"
+
+    sign_in @user
+
+    @push.notify_by_email_recipients = "test@test.com"
+    @push.notify_by_email_locale = "en"
+
+    assert_difference "AuditLog.count", 1 do
+      assert_difference "NotifyByEmail.count", 1 do
+        @controller.log_creation_email_send(@push)
+      end
+    end
+
+    assert_equal 1, AuditLog.count
+    log = AuditLog.last
+    assert_equal :creation_email_send, log.kind.to_sym
+    assert_equal @push, log.push
+    assert_equal "172.16.0.1", log.ip
+    assert_equal "TestAgent/1.0", log.user_agent
+    assert_equal "https://test.com", log.referrer
+
+    notify_by_email = NotifyByEmail.last
+    assert_equal "test@test.com", notify_by_email.recipients
+    assert_equal "en", notify_by_email.locale
+    assert_equal @push, notify_by_email.push
+    assert_equal "pending", notify_by_email.status
+  end
+
+  test "log_creation_email_send creates a SendPushCreatedEmailJob" do
+    sign_in @user
+
+    @push.notify_by_email_recipients = "test@test.com"
+    @push.notify_by_email_locale = "en"
+
+    assert_enqueued_with(job: SendPushCreatedEmailJob) do
+      @controller.log_creation_email_send(@push)
+    end
+
+    notify_by_email = NotifyByEmail.last
+    assert_enqueued_with(job: SendPushCreatedEmailJob, args: [notify_by_email.id])
+  end
+
+  test "log_creation_email_send does not create a job, audit_log or notify_by_email record when notify_by_email_recipients is blank" do
+    sign_in @user
+
+    @push.notify_by_email_recipients = ""
+
+    refute_enqueued_jobs do
+      assert_no_difference "AuditLog.count" do
+        assert_no_difference "NotifyByEmail.count" do
+          @controller.log_creation_email_send(@push)
+        end
+      end
+    end
+  end
+
   # Test log_failed_passphrase method
   test "log_failed_passphrase creates failed_passphrase audit log" do
     @request.env["REMOTE_ADDR"] = "192.168.0.1"