Clarify share message expiration copy. (#4657)

Content is deleted on expiration whether or not it was retrieved.
Fixes #4485

Co-authored-by: Peter Giacomo Lombardo <pglombardo@apnotic.com>

Author: pglombardo

app/helpers/share_message_helper.rb

@@ -11,7 +11,7 @@ def push_share_message_text(push, secret_url:, locale: nil)
       notes = [
         share_message_expiration_note(push),
         (passphrase_share_note if push.passphrase.present?),
-        I18n._("Once retrieved, the link and content will be deleted upon expiration.")
+        I18n._("The link and content will be deleted upon expiration.")
       ].compact
 
       [

test/helpers/share_message_helper_test.rb

@@ -18,6 +18,8 @@ class ShareMessageHelperTest < ActionView::TestCase
     assert_includes message, "IMPORTANT NOTES:"
     assert_includes message, @push.views_remaining.to_s
     assert_includes message, @push.days_remaining.to_s
+    assert_includes message, "The link and content will be deleted upon expiration."
+    assert_not_includes message, "Once retrieved"
   end
 
   test "push_share_message_text includes passphrase note when passphrase set" do