v5.3.1 add check for matching shared library

Author: keithf4

.gitignore

@@ -10,3 +10,4 @@ sql/*.sql
 test/not_working_yet/*
 *.zip
 *.fuse*
+.DS_Store

CHANGELOG.md

@@ -1,3 +1,12 @@
+5.3.1
+=====
+
+BUGFIXES
+--------
+ - In PostgreSQL 18, handle the case where the shared library used by the background worker may be a greater version than the installed version of pg_partman (Ex. new package installed, but the extension wasn't updated). This will cause an exception to avoid any unpredictable behavior. Note this can still happen with versions lower than 18, but the ability to give the shared library a trackable version was not added until 18.
+ - For all versions of PostgreSQL, throw a warning if the version of the extension that has been installed to the host system (default version) is different than the version that is installed in the database. Note this can cause the same issue as the above mismatched shared library, but it also accounts for other scenarios that are not as serious to warrant an error exception. (Github PR #799)
+
+
 5.3.0
 =====
 

META.json

@@ -1,7 +1,7 @@
 {
     "name": "pg_partman",
     "abstract": "Extension to manage partitioned tables by time or ID",
-    "version": "5.3.0",
+    "version": "5.3.1",
     "maintainer": [
         "Keith Fiske <[email protected]>"
     ],
@@ -20,9 +20,9 @@
     },
     "provides": {
         "pg_partman": {
-            "file": "sql/pg_partman--5.3.0.sql",
+            "file": "sql/pg_partman--5.3.1.sql",
             "docfile": "doc/pg_partman.md",
-            "version": "5.3.0",
+            "version": "5.3.1",
             "abstract": "Extension to manage partitioned tables by time or ID"
         }
     },

pg_partman.control

@@ -1,4 +1,4 @@
-default_version = '5.3.0'
+default_version = '5.3.1'
 comment = 'Extension to manage partitioned tables by time or ID'
 relocatable = false
 superuser = false

sql/functions/run_maintenance.sql

@@ -18,22 +18,24 @@ v_analyze                       boolean := FALSE;
 v_check_subpart                 int;
 v_child_timestamp               timestamptz;
 v_control_type                  text;
-v_exception                     boolean;
 v_time_encoder                  text;
 v_time_decoder                  text;
 v_create_count                  int := 0;
 v_current_partition_id          bigint;
 v_current_partition_timestamp   timestamptz;
 v_default_tablename             text;
+v_default_version               text;
 v_drop_count                    int := 0;
 v_exact_control_type            text;
+v_installed_version             text;
 v_is_default                    text;
 v_job_id                        bigint;
 v_jobmon_schema                 text;
 v_last_partition                text;
 v_last_partition_created        boolean;
 v_last_partition_id             bigint;
 v_last_partition_timestamp      timestamptz;
+v_library_version               text;
 v_max_id                        bigint;
 v_max_id_default                bigint;
 v_max_time_default              timestamptz;
@@ -61,8 +63,6 @@ v_sub_timestamp_max             timestamptz;
 v_sub_timestamp_max_suffix      timestamptz;
 v_sub_timestamp_min             timestamptz;
 v_tables_list_sql               text;
-v_default_version               text;
-v_installed_version             text;
 
 BEGIN
 /*
@@ -98,9 +98,19 @@ IF p_jobmon THEN
 END IF;
 EXECUTE format('SELECT set_config(%L, %L, %L)', 'search_path', v_new_search_path, 'false');
 
+IF current_setting('server_version_num')::int >= 180000 THEN
+    SELECT extversion INTO v_installed_version FROM pg_catalog.pg_extension WHERE extname = 'pg_partman';
+    SELECT version INTO v_library_version FROM pg_catalog.pg_get_loaded_modules() WHERE module_name = 'pg_partman';
+
+    IF replace(v_installed_version, '.', '')::int < replace(v_library_version, '.', '')::int THEN
+        RAISE EXCEPTION 'The installed version of pg_partman (%) is less than the shared library version file that has been loaded (%). Please ensure the expected version of pg_partman is installed to the system, update the extension if needed and restart the PostgreSQL instance.', v_installed_version, v_library_version;
+    END IF;
+END IF;
+
+-- Try and catch the same situation of a new library file existing on disk but the extension version not being updated properly in the database. Not as reliable as new feature in PG18, but better than nothing. Only do a warning since this is less definitely a problem than a known library mismatch.
 SELECT default_version, installed_version INTO v_default_version, v_installed_version FROM pg_available_extensions WHERE name = 'pg_partman' AND default_version != installed_version;
 IF v_installed_version IS NOT NULL THEN
-    RAISE WARNING 'pg_partman version % is installed but version % is default. run_maintenance might not work as expected. A restart might be required after update.', v_installed_version, v_default_version;
+    RAISE WARNING 'pg_partman version % is installed in the database but version % is the default available. Please ensure the expected version of pg_partman is installed to the system, update the extension in all relevant databases and restart the PostgreSQL instance if a new shared library module is available. See release notes for further details.', v_installed_version, v_default_version;
 END IF;
 
 IF v_jobmon_schema IS NOT NULL THEN
@@ -242,37 +252,31 @@ LOOP
         FOR v_row_max_time IN
             SELECT partition_schemaname, partition_tablename FROM @[email protected]_partitions(v_row.parent_table, 'DESC', false)
         LOOP
-            BEGIN
-                IF v_control_type = 'time' OR (v_control_type = 'id' AND v_row.epoch <> 'none') THEN
-                    EXECUTE format('SELECT %s::text FROM %I.%I LIMIT 1'
-                                        , v_partition_expression
-                                        , v_row_max_time.partition_schemaname
-                                        , v_row_max_time.partition_tablename
-                                    ) INTO v_child_timestamp;
-                ELSIF v_control_type IN ('text', 'uuid') THEN
-                    EXECUTE format('SELECT %s(%s::text) FROM %I.%I LIMIT 1'
-                                        , v_time_decoder
-                                        , v_partition_expression
-                                        , v_row_max_time.partition_schemaname
-                                        , v_row_max_time.partition_tablename
-                                    ) INTO v_child_timestamp;
-                END IF;
+            IF v_control_type = 'time' OR (v_control_type = 'id' AND v_row.epoch <> 'none') THEN
+                EXECUTE format('SELECT %s::text FROM %I.%I LIMIT 1'
+                                    , v_partition_expression
+                                    , v_row_max_time.partition_schemaname
+                                    , v_row_max_time.partition_tablename
+                                ) INTO v_child_timestamp;
+            ELSIF v_control_type IN ('text', 'uuid') THEN
+                EXECUTE format('SELECT %s(%s::text) FROM %I.%I LIMIT 1'
+                                    , v_time_decoder
+                                    , v_partition_expression
+                                    , v_row_max_time.partition_schemaname
+                                    , v_row_max_time.partition_tablename
+                                ) INTO v_child_timestamp;
+            END IF;
 
-                IF v_row.infinite_time_partitions AND v_child_timestamp < CURRENT_TIMESTAMP THEN
-                    -- No new data has been inserted relative to "now", but keep making child tables anyway
-                    v_current_partition_timestamp = CURRENT_TIMESTAMP;
-                    -- Nothing else to do in this case so just end early
-                    EXIT;
-                END IF;
-                IF v_child_timestamp IS NOT NULL THEN
-                    SELECT suffix_timestamp INTO v_current_partition_timestamp FROM @[email protected]_partition_name(v_row.parent_table, v_child_timestamp::text);
-                    EXIT;
-                END IF;
-            EXCEPTION WHEN others THEN
-                GET STACKED DIAGNOSTICS ex_message = MESSAGE_TEXT;
-                RAISE WARNING 'Child partition creation skipped for parent table %: %', v_row.parent_table, ex_message;
-                CONTINUE;
-            END;
+            IF v_row.infinite_time_partitions AND v_child_timestamp < CURRENT_TIMESTAMP THEN
+                -- No new data has been inserted relative to "now", but keep making child tables anyway
+                v_current_partition_timestamp = CURRENT_TIMESTAMP;
+                -- Nothing else to do in this case so just end early
+                EXIT;
+            END IF;
+            IF v_child_timestamp IS NOT NULL THEN
+                SELECT suffix_timestamp INTO v_current_partition_timestamp FROM @[email protected]_partition_name(v_row.parent_table, v_child_timestamp::text);
+                EXIT;
+            END IF;
         END LOOP;
         IF v_row.infinite_time_partitions AND v_child_timestamp IS NULL THEN
             -- If partition set is completely empty, still keep making child tables anyway
@@ -347,14 +351,8 @@ LOOP
                 CONTINUE;
             END;
 
-            BEGIN
-                v_last_partition_created := @[email protected]_partition_time(v_row.parent_table
+            v_last_partition_created := @[email protected]_partition_time(v_row.parent_table
                                                         , ARRAY[v_next_partition_timestamp]);
-            EXCEPTION WHEN others THEN
-                v_exception := true;
-                GET STACKED DIAGNOSTICS ex_message = MESSAGE_TEXT;
-                EXIT;
-            END;
 
             IF v_last_partition_created THEN
                 v_analyze := true;
@@ -445,13 +443,7 @@ LOOP
                 EXIT;
             END IF;
             v_next_partition_id := v_next_partition_id + v_row.partition_interval::bigint;
-            BEGIN
-                v_last_partition_created := @[email protected]_partition_id(v_row.parent_table, ARRAY[v_next_partition_id]);
-            EXCEPTION WHEN others THEN
-                v_exception := true;
-                GET STACKED DIAGNOSTICS ex_message = MESSAGE_TEXT;
-                EXIT;
-            END;
+            v_last_partition_created := @[email protected]_partition_id(v_row.parent_table, ARRAY[v_next_partition_id]);
             IF v_last_partition_created THEN
                 v_analyze := true;
                 v_create_count := v_create_count + 1;
@@ -466,13 +458,6 @@ LOOP
 
     END IF; -- end main IF check for time or id
 
-    -- on Exception with one table continue with the next
-    IF v_exception THEN
-        v_exception := false;
-        RAISE WARNING 'Child partition creation skipped for parent table %: %', v_row.parent_table, ex_message;
-        CONTINUE;
-    END IF;
-
     IF v_analyze AND p_analyze THEN
         IF v_jobmon_schema IS NOT NULL THEN
             v_step_id := add_step(v_job_id, format('Analyzing partition set: %s', v_row.parent_table));