Allow analyze to be optional in reapply constraints. Fix bug with dryrun (WAS: lock wait issues with reapply_constraints in Partman 5)

[jw1u1]

Hi,
after upgrading Partman 4.7 to 5.2 we face lock wait issues with reapply_constraints.
relation/AccessShare on the parent are waiting

`
LOG: duration: 324476.907 ms statement: call partman.reapply_constraints_proc('parent_table', false, true,0, true);

`
in dry-run, most time is spent with analysing the partitions.
seems like exclusive locks are kept during the final analyze.
No futher details so far.

[keithf4]

Hmm... not sure what's happening there. The time on constraint application vs analyze is all going to depend on the table size and constraint involved.

Reviewed the procedure and there are commits after each step that applies the constraint as far as I can see, so not sure that the analyze is the spot that's keeping the lock in place.

[keithf4]

So the dryrun is taking longer with the analyze because the analyze isn't skipped when doing the dry-run but the constraint application is. I'd consider that a bug actually and will try and fix that. Can also see about making the analyze a parameter flag to the procedure as well.

Doesn't answer what's keeping the lock after the upgrade, though. But the analyze being a flag would at least eliminate that

[jw1u1]

Commenting out analyze in the procedure did not change anything.
I did not find the root cause, we reduced traffic at the time of applying constraints to work around it.