perf: increase performance by using nonblocking timers

Author: ph1p

include/plugins/CirclePlugin.h

@@ -1,11 +1,13 @@
 #pragma once
 
 #include "PluginManager.h"
+#include "timing.h"
 
 class CirclePlugin : public Plugin
 {
 private:
   uint8_t circleStep = 0;
+  NonBlockingDelay timer;
   std::vector<std::vector<int>> frames = {
       {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
        0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,

include/plugins/LinesPlugin.h

@@ -1,11 +1,13 @@
 #pragma once
 
 #include "PluginManager.h"
+#include "timing.h"
 
 class LinesPlugin : public Plugin
 {
 private:
   uint8_t count = 0;
+  NonBlockingDelay timer;
   std::vector<std::vector<int>> frames = {{0xcc, 0xcc}, {0x66, 0x66}, {0x33, 0x33}, {0x99, 0x99}};
 
 public:

include/plugins/RainPlugin.h

@@ -1,10 +1,12 @@
 #pragma once
 
 #include "PluginManager.h"
+#include "timing.h"
 
 class RainPlugin : public Plugin
 {
 private:
+  NonBlockingDelay timer;
   static constexpr uint8_t NUM_DROPS = 10;
   static constexpr uint8_t X_MAX = 16;
   static constexpr uint8_t Y_MAX = 16;

include/scheduler.h

@@ -17,6 +17,10 @@ class PluginScheduler
   unsigned long lastSwitch = 0;
   size_t currentIndex = 0;
 
+  bool needsPersist = false;
+  unsigned long lastPersistRequest = 0;
+  static constexpr unsigned long PERSIST_DELAY_MS = 2000;
+
 public:
   static PluginScheduler &getInstance();
 
@@ -36,6 +40,8 @@ class PluginScheduler
 
 private:
   void switchToCurrentPlugin();
+  void requestPersist();
+  void checkAndPersist();
 };
 
 extern PluginScheduler &Scheduler;

src/main.cpp

@@ -199,7 +199,7 @@ void screenDrawingTask(void *parameter)
   for (;;)
   {
     pluginManager.runActivePlugin();
-    vTaskDelay(10);
+    vTaskDelay(1);
   }
 }
 

src/messages.cpp

@@ -55,8 +55,6 @@ void Messages_::remove(int id)
 
 void Messages_::scroll()
 {
-  Screen.persist();
-
   for (auto it = activeMessages.begin(); it != activeMessages.end();)
   {
     Message *msg = *it;
@@ -84,11 +82,6 @@ void Messages_::scroll()
       ++it;
     }
   }
-
-  if (currentStatus == NONE)
-  {
-    Screen.loadFromStorage();
-  }
 }
 
 void Messages_::scrollMessageEveryMinute()
@@ -107,8 +100,12 @@ void Messages_::scrollMessageEveryMinute()
     {
       if (!activeMessages.empty())
       {
-        indicatorPixel = timeinfo.tm_sec & 0b00000001;
-        Screen.setPixel(0, 0, indicatorPixel);
+        uint8_t newIndicatorPixel = timeinfo.tm_sec & 0b00000001;
+        if (newIndicatorPixel != indicatorPixel)
+        {
+          indicatorPixel = newIndicatorPixel;
+          Screen.setPixel(0, 0, indicatorPixel);
+        }
       }
       else if (indicatorPixel > 0)
       {

src/plugins/CirclePlugin.cpp

@@ -7,6 +7,9 @@ void CirclePlugin::setup()
 
 void CirclePlugin::loop()
 {
+  if (!timer.isReady(200))
+    return;
+
   std::vector<int> bits = Screen.readBytes(this->frames[this->circleStep]);
 
   for (int i = 0; i < bits.size(); i++)
@@ -19,7 +22,6 @@ void CirclePlugin::loop()
   {
     this->circleStep = 7;
   }
-  delay(200);
 }
 
 const char *CirclePlugin::getName() const

src/plugins/LinesPlugin.cpp

@@ -7,6 +7,9 @@ void LinesPlugin::setup()
 
 void LinesPlugin::loop()
 {
+  if (!timer.isReady(200))
+    return;
+
   std::vector<int> bits = Screen.readBytes(this->frames[this->count]);
   for (int row = 0; row < ROWS; row++)
   {
@@ -21,7 +24,6 @@ void LinesPlugin::loop()
   {
     this->count = 0;
   }
-  delay(200);
 }
 
 const char *LinesPlugin::getName() const

src/plugins/RainPlugin.cpp

@@ -14,6 +14,9 @@ void RainPlugin::setup()
 
 void RainPlugin::loop()
 {
+  if (!timer.isReady(96))
+    return;
+
   // dim the trail
   for (uint8_t x = 0; x < RainPlugin::X_MAX; x++)
   {
@@ -59,8 +62,6 @@ void RainPlugin::loop()
       Screen.setPixel(this->drops[i].x, this->drops[i].y, RainPlugin::LED_TYPE_ON, 255);
     }
   }
-
-  delay(96);
 }
 
 const char *RainPlugin::getName() const

src/scheduler.cpp

@@ -44,27 +44,42 @@ void PluginScheduler::start()
     currentIndex = 0;
     lastSwitch = millis();
     isActive = true;
-#ifdef ENABLE_STORAGE
-    storage.begin("led-wall", false);
-    storage.putInt("scheduleactive", 1);
-    storage.end();
-#endif
+    requestPersist();
     switchToCurrentPlugin();
   }
 }
 
 void PluginScheduler::stop()
 {
   isActive = false;
+  requestPersist();
+}
+
+void PluginScheduler::requestPersist()
+{
+  needsPersist = true;
+  lastPersistRequest = millis();
+}
+
+void PluginScheduler::checkAndPersist()
+{
 #ifdef ENABLE_STORAGE
-  storage.begin("led-wall", false);
-  storage.putInt("scheduleactive", 0);
-  storage.end();
+  if (needsPersist && (millis() - lastPersistRequest >= PERSIST_DELAY_MS))
+  {
+    storage.begin("led-wall", false);
+    storage.putInt("scheduleactive", isActive ? 1 : 0);
+    storage.end();
+    needsPersist = false;
+  }
+#else
+  needsPersist = false;
 #endif
 }
 
 void PluginScheduler::update()
 {
+  checkAndPersist();
+
   if (!isActive || schedule.empty())
     return;