Coverity Scan fixes

Author: rouault

src/iso19111/c_api.cpp

@@ -217,7 +217,8 @@ PJ *pj_obj_create(PJ_CONTEXT *ctx, const BaseObjectNNPtr &objIn) {
                         ? ctx->get_cpp_context()->getDatabaseContextIfOpen()
                         : nullptr;
                 auto formatter = PROJStringFormatter::create(
-                    PROJStringFormatter::Convention::PROJ_5, dbContext);
+                    PROJStringFormatter::Convention::PROJ_5,
+                    std::move(dbContext));
                 auto projString = coordop->exportToPROJString(formatter.get());
                 const bool defer_grid_opening_backup = ctx->defer_grid_opening;
                 if (!defer_grid_opening_backup &&

src/iso19111/common.cpp

@@ -119,12 +119,7 @@ UnitOfMeasure &UnitOfMeasure::operator=(const UnitOfMeasure &other) {
 // ---------------------------------------------------------------------------
 
 //! @cond Doxygen_Suppress
-UnitOfMeasure &UnitOfMeasure::operator=(UnitOfMeasure &&other) {
-    *d = std::move(*(other.d));
-    other.d = nullptr;
-    BaseObject::operator=(std::move(static_cast<BaseObject &&>(other)));
-    return *this;
-}
+UnitOfMeasure &UnitOfMeasure::operator=(UnitOfMeasure &&) = default;
 //! @endcond
 
 // ---------------------------------------------------------------------------

test/unit/test_common.cpp

@@ -67,6 +67,16 @@ TEST(common, unit_of_measure) {
     EXPECT_EQ(Angle(2.5969213, UnitOfMeasure::GRAD)
                   .convertToUnit(UnitOfMeasure::DEGREE),
               2.5969213 / 100.0 * 90.0);
+
+    {
+        UnitOfMeasure myUOM("myUOM", 123);
+        UnitOfMeasure myUOM_copy;
+        myUOM_copy = myUOM;
+        EXPECT_TRUE(myUOM == myUOM_copy);
+        UnitOfMeasure otherUOM("otherUOM", 456);
+        otherUOM = std::move(myUOM);
+        EXPECT_TRUE(otherUOM == myUOM_copy);
+    }
 }
 
 // ---------------------------------------------------------------------------