[BUG]: v4 Regression - localhost/project/ - trouble with Application->handle

[jenovateurs]

Config

Windows 10 - Wamp - PHP 7.2.18

Description

With Phalcon V3, I can have multiple project at the root of the server like :
http://localhost/project/
http://localhost/project2/
...
With Phalcon V4, I get this error:

HelloWorld2Controller handler class cannot be loaded

#0 [internal function]: Phalcon\Mvc\Dispatcher->throwDispatchException('HelloWorld2Cont...', 2)
#1 [internal function]: Phalcon\Dispatcher\AbstractDispatcher->dispatch()
#2 E:\wamp64\www\hello_world2\public\index.php(45): Phalcon\Mvc\Application->handle('/hello_world2/')
#3 {main}

Little hack

To solve temporary this issue, I updated the file public/index.php:
echo $application->handle($_SERVER['REQUEST_URI'])->getContent();
to
echo $application->handle(str_replace('hello_world2/','',$_SERVER['REQUEST_URI']))->getContent();
But, It's not very great.

[ruudboon]

@jenovateurs You're on Phalcon 4.0.0-RC.3?

[jenovateurs]

@ruudboon Yes, I'm on Phalcon 4.0.0-rc.3.

[ruudboon]

@jenovateurs could you try to pass in $_GET["_url"]. That was the default in 3.4

$application->handle($_GET["_url"])->getContent();

[jenovateurs]

@ruudboon When I tried with $_GET["_url"], I got this error :

Notice: Undefined index: _url in E:\wamp64\www\test\public\index.php on line 43
Fatal  error: Uncaught TypeError: Argument 1 passed to  Phalcon\Mvc\Application::handle() must be of the type string, null given  in E:\wamp64\www\test\public\index.php on line 43

[ruudboon]

@jenovateurs And you are using the same Apache or Nginx config as your 3.4 environment? I did some comparison between 4 and 3.4 on this point I don't see any changes that could cause this behaviour. Also on my test machine I was able to run directory based on the $_GET["_url"] (using nginx).

[jenovateurs]

@ruudboon Yes, I used the same Apache configuration. I just changed the Phalcon extension.

I took a project created with v3 and I have no problem. But when I put the parameter $_SERVER['REQUEST_URI'] in the handle function, it's like I'm always in the indexAction. No error is triggered even if I add some parameters in the URI.

When I took a v4 project, I had the same error :
TestController handler class cannot be loaded
But when I deleted $_SERVER['REQUEST_URI'] from handle, I had a normal error:
Uncaught Error: Class 'Phalcon\Url' not found in

When I called this URL: http://127.0.0.1/test/ with Apache
$_SERVER['REQUEST_URI'] return /test/

With Nginx, do you have the same value ?

[ruudboon]

@jenovateurs Nginx will strip out the dir. Config looks something like this. $1 will only hold the part after the '/'. I will have a look at this with apache.

location / {
        try_files $uri $uri/ @rewrite;
}
location @rewrite {
        rewrite ^(.*)$ /index.php?_url=$1;
}

[jenovateurs]

@ruudboon
Thanks for the Nginx information.
I think, I have understood the problem.
When I called this URL : http://127.0.0.1/test/
$_GET['_url'] was null and it's generated an error because handle expected a non-null value.
When I called this URL : http://127.0.0.1/test/utilisateur
$_GET['_url'] wasn't null and worked well.
So now, I do that:
echo $application->handle($_GET['_url'] ?? '/')->getContent();
What do you think ?
I found this solution by reading the code of the router in v3 : https://github.com/phalcon/cphalcon/blob/3.4.x/phalcon/mvc/router.zep
I saw this function :

public function getRewriteUri() -> string
	{
		var url, urlParts, realUri;

		/**
		 * By default we use $_GET["url"] to obtain the rewrite information
		 */
		if !this->_uriSource {
			if fetch url, _GET["_url"] {
				if !empty url {
					return url;
				}
			}
		} else {
			/**
			 * Otherwise use the standard $_SERVER["REQUEST_URI"]
			 */
			if fetch url, _SERVER["REQUEST_URI"] {
				let urlParts = explode("?", url),
					realUri = urlParts[0];
				if !empty realUri {
					return realUri;
				}
			}
		}
		return "/";
	}

And if I understand well, if $_GET['_url'] is null, the function returns '/'.
So is it an issue concerning the generation of projects with phalcon/devtools ?
Need to change $_SERVER['REQUEST_URI'] to $_GET['_url'] ?? '/' ?