ex_hoanglx ex1~ex6 #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoanglx-2672
force-pushed
the
hoanglx_ex1_ex6
branch
from
bd44d94 to
26dc269
Compare
phantien133
reviewed
Jan 24, 2024
ex1_hoanglx/ex5.ts
Outdated
| console.log(` - ${person.name}, ${person.age}, ${additionalInformation}`); | ||
| } | ||
|
|
||
| export function filterUsers(persons: Person[], criteria: Pick<Person, Exclude<keyof Person, "name" | "occupation" | "type" >>): User[] { |
phantien133
reviewed
Jan 24, 2024
ex1_hoanglx/ex6.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export function filterPersons(persons: Person[], personType: string, criteria: unknown): Person[] { |
Owner
There was a problem hiding this comment.
unknown mà giải quyết vấn đề gì, làm nghiêm chỉnh vào coi
added 2 commits
January 25, 2024 00:01
hoanglx-2672
force-pushed
the
hoanglx_ex1_ex6
branch
from
26dc269 to
8abca60
Compare
phantien133
reviewed
Jan 25, 2024
ex1_hoanglx/ex5.ts
Outdated
| console.log(` - ${person.name}, ${person.age}, ${additionalInformation}`); | ||
| } | ||
|
|
||
| export function filterUsers(persons: Person[], criteria: Omit<Person, "name" | "occupation" | "type" >): User[] { |
phantien133
reviewed
Jan 25, 2024
ex1_hoanglx/ex6.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export function filterPersons(persons: Person[], personType: string, criteria: Omit<Person, "name" | "type" >): Person[] { |
Author
There was a problem hiding this comment.
@phantien133 code này vẫn chạy được nghe anh theo em nghỉ là thằng occupation và role không thuộc đối tượng bắt buộc của Person nên lúc này mình chỉ cần exclude name và type ra ngoài thôi anh, còn nếu define thì nó thừa mất
em ko biết là mình hiểu đúng ko nữa nhưng mà thấy chạy được và ko mất thông tin nào cả. tương tự bài 5 cũng vậy anh
Owner
There was a problem hiding this comment.
@hoanglx-2672 chạy đc là 1 chuyện, đúng hay sai là chuyện khác
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.