[TrungPH] Submit exercise 1 -> 10 #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phantien133
reviewed
Jan 24, 2024
TrungPH/ex2.ts
Outdated
| console.log(` - ${person.name}, ${person.age}`); | ||
| } | ||
|
|
||
| persons.forEach(logPerson); No newline at end of file |
Owner
There was a problem hiding this comment.
config editor auto add empty line vào cuối file đi em
TrungPH/ex4.ts
Outdated
| export function logPerson(person: Person) { | ||
| let additionalInformation: string = ''; | ||
| if (isAdmin(person)) { | ||
| additionalInformation = (person as Admin).role; |
Owner
There was a problem hiding this comment.
ntn hợp lý, k sai
cơ mà làm các bài sau rồi, e có để cách ng ta dùng hàm để xác định type luôn cho 1 object k?
check rồi update thử xem
TrungPH/ex6.ts
Outdated
| ); | ||
| } | ||
|
|
||
| export function getObjKeys<T extends object>(obj: T): (keyof T)[] { |
Owner
There was a problem hiding this comment.
T extends object thì thôi T là đc e ạ
| return Object.keys(obj) as (keyof T)[]; | ||
| } | ||
|
|
||
| export function filterPersons(persons: Person[], personType: string, criteria: Partial<Person>): Person[] { |
Owner
There was a problem hiding this comment.
có cách nào để xác định đc luôn khi gọi hàm thfi object trả về là User[] hay Admin[] luôn k em
vì ngay khi truyền personType là đã xác định đc r
TrungPH/ex9.ts
Outdated
| } | ||
| ); | ||
|
|
||
| type AdminsApiResponse = ( |
Owner
There was a problem hiding this comment.
thử dùng generic type ở ApiResponse để tránh lặp lại 2 type mới khá trùng nhau ntn đc k e
Owner
|
@htrung1303 update phát em |
Author
@phantien133 Em done anh oi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mong anh bửa nhẹ tay 🙏