Skip to content

Spec tools should not refer directly to Smalltalk tools #1211

@Ducasse

Description

@Ducasse

We should check all the users of toolNamed: and make sure that they use application toolNamed:

  • Epciea does it well.

Possible list of things to fix: (open an issue for each group).

  • We should introduce a quality rule that check if the class is a Spec subclass then we should not have a reference to Smalltalk tools.

  • IceTipMergePresenter >> changesTreeActions

  • StNode >> browseClass: if StNode does not know the application then the applicaiton should be passed to it at creation time (from the presenter that instantiate it).

  • StTranscriptPresenter >> menuCommandOn:

  • Please expand the list by analysis the senders of toolNamed:...

  • In some cases the logic should be changed. For example the CompiledMethod drTest.... cannot use application because the way is it done. The presenter should do something different. To be studied.
    We could use some double dispatch.

Instead of

browseSelectedItem
	"Because of DTBrowseSelectedItem>>#canBeExecuted, we know there is a single item in the selection.
	 Thus, we take the first one and browse it.
	"
	self selectedItems first drTestsBrowse
browseSelectedItem
	"Because of DTBrowseSelectedItem>>#canBeExecuted, we know there is a single item in the selection.
	 Thus, we take the first one and browse it.
	"
	self selectedItems first testBrowse: self 

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions