Add module: "NodeNext" support to @betterer/typescript

[oceanEcho]

I'm trying to run @betterer/typescript with { "module": "NodeNext", "moduleResolution": "nodenext" } TypeScript configuration but keep getting an error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'. error

Seems like betterer rewriting my module configuration option by own value which is not compatible with nodenext module resolution

[phenomnomnominal]

Just want to confirm this is for v5 not v6 alpha?

[oceanEcho]

Yes, it’s 5.4.0 version

By the way i tried v6 alpha version but after run it just removed all errors from result so i decided to remain on 5 version

[phenomnomnominal]

Getting NodeNext to work with v5 is functionally impossible (because I made some bad choices). If you can give me more details to try to understand what happened in v6 that would be great.

[oceanEcho]

Node v20.12.0
pnpm v8.15.0

"@betterer/cli": "6.0.0-alpha.1",
"@betterer/typescript": "6.0.0-alpha.1",

tsconfig.json

{
  "compilerOptions": {
    "jsx": "react",
    // Target latest version of ECMAScript.
    "target": "esnext",
    "lib": ["dom", "esnext"],
    "module": "node16",
    // Search under node_modules for non-relative imports.
    "moduleResolution": "node16",
    // Process & infer types from .js files.
    "allowJs": true,
    // Don't emit; allow Babel to transform files.
    "noEmit": true,
    // Enable strictest settings like strictNullChecks & noImplicitAny.
    // @TODO enable when all be in typescript
    "strict": false,
    "strictNullChecks": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    // Disallow features that require cross-file information for emit.
    "isolatedModules": true,
    // Import non-ES modules as default imports.
    "esModuleInterop": true,
    "baseUrl": "./src",
    "useDefineForClassFields": true,
    "resolveJsonModule": true,
    "allowImportingTsExtensions": true
  },
  "include": [
    "src",
    //    "__mocks__",
    //    "__tests__",
    //    "configs",
    ".storybook"
  ],
  "exclude": ["node_modules/*"]
}

@betterer/typescript config

import { typescript } from '@betterer/typescript';

export const strictTypescriptErrors = () =>
  typescript('../tsconfig.json', {
    strict: true,
    noEmit: true,
  }).include('../src/**/*.ts', '../src/**/*.tsx');

I'm running this command

"strict-ts-check": "betterer --config ./tools/strictTypescriptErrors.ts --results ./tools/strictTypescriptErrors.results",

And getting this result but my code have a lot of typescript errors and v5 version 5 found them (before command there was 10k+ errors)

// BETTERER RESULTS V2.
//
// If this file contains merge conflicts, use `betterer merge` to automatically resolve them:
// https://phenomnomnominal.github.io/betterer/docs/results-file/#merge
//
exports[`strictTypescriptErrors`] = {
  value: `{}`
};

[phenomnomnominal]

Are you able to debug it at all? Specifically seeing if it reaches here and what happens?