Problems building an RC

[jbphet]

I just built an RC for Isotopes and Atomic Mass, and I think this might be the first RC since we partially switched to a monorepo, and maybe the first one since we added package-lock.json files. I ran into some glitches, and @samreid helped work through them. He and I thought an issue should be logged in case others run into this.

Note that this RC build had to be done from the polyrepos because RC builds from the monorepo are not yet supported.

The initial attempt at the build failed somewhere during the creation of the release breach and updates of the version numbers. Here is the console output that I saw:

Details

info: Setting version from package.json for isotopes-and-atomic-mass to 1.3.0-dev.0
info: git add package.json on isotopes-and-atomic-mass
info: git add package-lock.json on isotopes-and-atomic-mass
info: git commit on isotopes-and-atomic-mass with message:
Bumping isotopes-and-atomic-mass version to 1.3.0-dev.0
C:\Users\john\git-dev\perennial\js\common\execute.ts:154
            reject( new ExecuteError( cmd, args, cwd, stdout, stderr, code, Date.now() - startTime ) );
                    ^


ExecuteError: git commit --no-verify -m Bumping isotopes-and-atomic-mass version to 1.3.0-dev.0 in ../isotopes-and-atomic-mass failed with exit code 1
stdout:
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

    at ChildProcess.<anonymous> (C:\Users\john\git-dev\perennial\js\common\execute.ts:154:21)
    at ChildProcess.emit (node:events:518:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5) {
  cmd: 'git',
  args: [
    'commit',
    '--no-verify',
    '-m',
    'Bumping isotopes-and-atomic-mass version to 1.3.0-dev.0'
  ],
  cwd: '../isotopes-and-atomic-mass',
  stdout: 'On branch main\n' +
    "Your branch is up to date with 'origin/main'.\n" +
    '\n' +
    'nothing to commit, working tree clean\n',
  stderr: '',
  code: 1,
  time: 32
}

Node.js v22.17.0

It wasn't obvious why this failed, and the branch did in fact get created and the version numbers in the respective package.json files were correct. So, after @samreid and I spent some time investigating, I ultimately just retried the build, thinking that it would skip the branch creation code, which it did. It got farther this time, but then ran into the error where an npm update fails because of something with our development server (@samreid is familiar with this problem, so I won't elaborate here). To get around that, I manually reverted the version number on the branch, killed my dev server, and kicked of the RC build command again. This time it worked.

Maybe there is something in my environment that made this so problematic, but we should keep tabs on whether other devs hit similar issues and resolve them if so.

[samreid]

@jonathanolson any idea why @jbphet got a nothing to commit, working tree clean in setRepoVersion in this code:

  else if ( !await gitIsClean( repo ) ) {
    await gitAdd( repo, 'package.json' );
    if ( fs.existsSync( packageLockFile ) ) {
      await gitAdd( repo, 'package-lock.json' );
    }
    await gitCommit( repo, `Bumping ${repo} version to ${version.toString()}${message ? `, ${message}` : ''}` );
  }