Skip to content

Commit 9a2d73b

Browse files
authored
feat: Migrate to CodeAnalysis 4.4, ending support for VS2019 (#1095)
1 parent 045275c commit 9a2d73b

24 files changed

+66
-51
lines changed

Directory.Build.Analyzer.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@
3333
</PropertyGroup>
3434

3535
<ItemGroup>
36-
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.0.0">
36+
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.3.3">
3737
<PrivateAssets>all</PrivateAssets>
3838
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3939
</PackageReference>
40-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.6.0" PrivateAssets="all" />
40+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.4.0" PrivateAssets="all" />
4141
<PackageReference Update="NETStandard.Library" PrivateAssets="all" />
4242
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
4343
<PackageReference Include="ILRepack.Lib.MSBuild.Task" Version="2.0.34.2" PrivateAssets="all" ExcludeAssets="build" />

Philips.CodeAnalysis.Benchmark/Philips.CodeAnalysis.Benchmark.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<ItemGroup>
1212
<PackageReference Include="BenchmarkDotNet" Version="0.12.1" />
1313
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" Version="0.12.1" />
14-
<PackageReference Include="Microsoft.CodeAnalysis" Version="3.6.0" />
14+
<PackageReference Include="Microsoft.CodeAnalysis" Version="4.4.0" />
1515
</ItemGroup>
1616

1717
<ItemGroup>

Philips.CodeAnalysis.Common/Philips.CodeAnalysis.Common.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<AssemblyVersion>1.0.3.0</AssemblyVersion>
88
</PropertyGroup>
99
<ItemGroup>
10-
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.6.0" />
10+
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.4.0" />
1111
<PackageReference Include="Mono.Cecil" Version="0.11.6" />
1212
</ItemGroup>
1313
</Project>

Philips.CodeAnalysis.MaintainabilityAnalyzers/Documentation/XmlDocumentationCodeFixProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ protected override async Task<Document> ApplyFix(Document document, SyntaxNode n
2727
SyntaxNode newRoot = root;
2828
foreach (SyntaxTrivia trivia in node.GetLeadingTrivia())
2929
{
30-
if (trivia.Kind() == SyntaxKind.SingleLineDocumentationCommentTrivia)
30+
if (trivia.IsKind(SyntaxKind.SingleLineDocumentationCommentTrivia))
3131
{
3232
newRoot = newRoot.ReplaceTrivia(trivia, SyntaxTriviaList.Empty);
3333
}

Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidAsyncVoidAnalyzer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ private void AnalyzeLambda(SyntaxNodeAnalysisContext context)
4242
{
4343
var lambdaExpressionSyntax = (LambdaExpressionSyntax)context.Node;
4444

45-
if (lambdaExpressionSyntax.AsyncKeyword.Kind() != SyntaxKind.AsyncKeyword)
45+
if (!lambdaExpressionSyntax.AsyncKeyword.IsKind(SyntaxKind.AsyncKeyword))
4646
{
4747
return;
4848
}
@@ -70,7 +70,7 @@ private void Analyze(INamedTypeSymbol namedSymbol, SyntaxNodeAnalysisContext con
7070
return;
7171
}
7272

73-
if (methodDeclaration.ReturnType is not PredefinedTypeSyntax predefinedTypeSyntax || predefinedTypeSyntax.Keyword.Kind() != SyntaxKind.VoidKeyword)
73+
if (methodDeclaration.ReturnType is not PredefinedTypeSyntax predefinedTypeSyntax || !predefinedTypeSyntax.Keyword.IsKind(SyntaxKind.VoidKeyword))
7474
{
7575
return;
7676
}

Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidPublicMemberVariableAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public class AvoidPublicMemberVariableSyntaxNodeAction : SyntaxNodeAction<FieldD
2424
{
2525
public override void Analyze()
2626
{
27-
if (Node.Parent.Kind() == SyntaxKind.StructDeclaration)
27+
if (Node.Parent.IsKind(SyntaxKind.StructDeclaration))
2828
{
2929
return;
3030
}

Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidStaticClassesAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public void Analyze(SyntaxNodeAnalysisContext context)
103103
}
104104
}
105105

106-
Location location = classDeclarationSyntax.Modifiers.First(t => t.Kind() == SyntaxKind.StaticKeyword).GetLocation();
106+
Location location = classDeclarationSyntax.Modifiers.First(t => t.IsKind(SyntaxKind.StaticKeyword)).GetLocation();
107107
var diagnostic = Diagnostic.Create(AvoidStaticClassesAnalyzer.Rule, location);
108108
context.ReportDiagnostic(diagnostic);
109109
}

Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/AvoidStaticMethodAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public override void Analyze()
8383
return;
8484
}
8585

86-
Location location = Node.Modifiers.First(t => t.Kind() == SyntaxKind.StaticKeyword).GetLocation();
86+
Location location = Node.Modifiers.First(t => t.IsKind(SyntaxKind.StaticKeyword)).GetLocation();
8787
ReportDiagnostic(location);
8888
}
8989

Philips.CodeAnalysis.MaintainabilityAnalyzers/Maintainability/MergeIfStatementsAnalyzer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public override void Analyze()
7474

7575
private bool IfConditionHasLogicalAnd(IfStatementSyntax ifStatement)
7676
{
77-
return ifStatement.Condition.DescendantTokens().Any((token) => { return token.Kind() == SyntaxKind.BarBarToken; });
77+
return ifStatement.Condition.DescendantTokens().Any((token) => { return token.IsKind(SyntaxKind.BarBarToken); });
7878
}
7979
}
8080
}

Philips.CodeAnalysis.MaintainabilityAnalyzers/Naming/EnforceBoolNamingConventionAnalyzer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,12 +232,12 @@ private bool IsTypeBool(TypeSyntax typeSyntax, SemanticModel semanticModel)
232232

233233
private bool IsFieldPublic(FieldDeclarationSyntax fieldDeclaration)
234234
{
235-
return fieldDeclaration.Modifiers.Any(x => x.Kind() == SyntaxKind.PublicKeyword);
235+
return fieldDeclaration.Modifiers.Any(x => x.IsKind(SyntaxKind.PublicKeyword));
236236
}
237237

238238
private bool IsFieldConst(FieldDeclarationSyntax fieldDeclaration)
239239
{
240-
return fieldDeclaration.Modifiers.Any(x => x.Kind() == SyntaxKind.ConstKeyword);
240+
return fieldDeclaration.Modifiers.Any(x => x.IsKind(SyntaxKind.ConstKeyword));
241241
}
242242
}
243243
}

0 commit comments

Comments
 (0)