ci: Update SonarCloud workflow to use token variable (#1077)

Author: bcollamore

.github/workflows/sonarcloud.yml

@@ -28,12 +28,11 @@ jobs:
           dotnet tool update dotnet-sonarscanner --global
           dotnet tool update dotnet-coverage --global
       - name: Build and analyze
-        if: ${{ env.SONAR_TOKEN != null }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.sonar-auth-token }}
         run: |
-          dotnet sonarscanner begin /k:"philips-software_roslyn-analyzers" /o:"philips-software" /d:sonar.login="${{ secrets.sonar-auth-token }}" /d:sonar.cs.vscoveragexml.reportsPaths="coverage.xml" /d:sonar.host.url="https://sonarcloud.io"
+          dotnet sonarscanner begin /k:"philips-software_roslyn-analyzers" /o:"philips-software" /d:sonar.token="$SONAR_TOKEN" /d:sonar.cs.vscoveragexml.reportsPaths="coverage.xml" /d:sonar.host.url="https://sonarcloud.io"
           dotnet build --configuration Debug
-          dotnet coverage collect 'dotnet test' -f xml  -o 'coverage.xml'
-          dotnet sonarscanner end /d:sonar.login="${{ secrets.sonar-auth-token }}"
+          dotnet coverage collect 'dotnet test' -f xml -o 'coverage.xml'
+          dotnet sonarscanner end /d:sonar.token="$SONAR_TOKEN"