Update docs, add validations check for Container Host

Author: loafoe

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## v0.7.4
+- Add validation checks and update documentatin for Container Host
+
 ## v0.7.3
 - Implement data.hsdp_iam_service
 

Dockerfile

@@ -1,6 +1,6 @@
-ARG hsdp_provider_version=0.7.1
+ARG hsdp_provider_version=0.7.4
 
-FROM golang:1.15.5-alpine3.12 as build_base
+FROM golang:1.15.6-alpine3.12 as build_base
 RUN apk add --no-cache git openssh gcc musl-dev
 WORKDIR /terraform-provider-hsdp
 COPY go.mod .
@@ -15,7 +15,7 @@ FROM build_base AS builder
 COPY . .
 RUN ./buildscript.sh
 
-FROM hashicorp/terraform:0.13.5
+FROM hashicorp/terraform:0.14.2
 ARG hsdp_provider_version
 ENV HSDP_PROVIDER_VERSION ${hsdp_provider_version}
 LABEL maintainer="Andy Lo-A-Foe <andy.lo-a-foe@philips.com>"

README.md

@@ -12,14 +12,14 @@ To find out more about HSDP please visit https://www.hsdp.io/
 
 # Using the provider
 
-**Terraform 0.13**: To install this provider, copy and paste this code into your Terraform configuration. Then, run terraform init.
+**Terraform 0.13+**: To install this provider, copy and paste this code into your Terraform configuration. Then, run terraform init.
 
 ```terraform
 terraform {
   required_providers {
     hsdp = {
       source = "philips-software/hsdp"
-      version = ">= 0.7.3"
+      version = ">= 0.7.4"
     }
   }
 }

docs/resources/container_host.md

@@ -47,12 +47,12 @@ The following arguments are supported:
 * `name` - (Required) The container host name. Must be unique.
 * `instance_type` - (Optional) The EC2 instance type to use. Default `m5.large`
 * `instance_role` - (Optional) The role to use. Default `container-host` (other values: `vanilla`, `base`)
-* `volume_type` - (Optional) The EBS volume type.
-* `iops` - (Optional) Number of IOPs to provision.
+* `volume_type` - (Optional) The EBS volume type. Default is `gp2`. You can also choose `io1` which is default when you specify `iops` value
+* `iops` - (Optional) Number of guaranteed IOPs to provision. Supported value range `1-4000`
 * `protect` - (Optional) Boolean when set will enable protection for container host.
 * `encrypt_volumes` - (Optional) When set encrypts volumes. Default is `true`
-* `volumes` - (Optional) Number of additional volumes to attach. Default `0`
-* `volume_size` - (Optional) Volume size in GB.
+* `volumes` - (Optional) Number of additional volumes to attach. Default `0`, Maximum `6`
+* `volume_size` - (Optional) Volume size in GB. Supported value range `1-1000` (1 TB max)
 * `security_groups` - (Optional) list(string) of Security groups to attach. Default `[]`
 * `user_groups` - (Optional) list(string) of User groups to attach. Default `[]`
 * `tags` - (Optional) Map of tags to assign to the instances

hsdp/resource_container_host.go

@@ -6,6 +6,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"github.com/philips-software/go-hsdp-api/cartel"
 	"log"
 	"net/http"
@@ -64,9 +65,10 @@ func resourceContainerHost() *schema.Resource {
 				ForceNew: true,
 			},
 			"iops": {
-				Type:     schema.TypeInt,
-				Optional: true,
-				ForceNew: true,
+				Type:         schema.TypeInt,
+				Optional:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.IntBetween(1, 4000),
 			},
 			"protect": {
 				Type:     schema.TypeBool,
@@ -80,16 +82,18 @@ func resourceContainerHost() *schema.Resource {
 				ForceNew: true,
 			},
 			"volumes": {
-				Type:     schema.TypeInt,
-				Default:  0,
-				Optional: true,
-				ForceNew: true,
+				Type:         schema.TypeInt,
+				Default:      0,
+				Optional:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.IntBetween(0, 6),
 			},
 			"volume_size": {
-				Type:     schema.TypeInt,
-				Default:  0,
-				Optional: true,
-				ForceNew: true,
+				Type:         schema.TypeInt,
+				Default:      0,
+				Optional:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.IntBetween(0, 1000),
 			},
 			"security_groups": {
 				Type:     schema.TypeSet,