Skip to content

Commit 5334b0b

Browse files
philoserfclaude
andcommitted
fix: add trailing newlines in version-bump, remove redundancy in validate
- version-bump.ts: append newline to JSON output for POSIX compliance - validate-plugin.ts: remove redundant typecheck step (check includes it), call build.ts/vite directly (build script re-runs check) Closes sort-lines#9, vault-changelog#103, vault-review#3 Closes sort-lines#8, vault-changelog#102 Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent da35178 commit 5334b0b

File tree

2 files changed

+3
-23
lines changed

2 files changed

+3
-23
lines changed

scripts/validate-plugin.ts

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,6 @@ try {
3232
errors++;
3333
}
3434

35-
// Run TypeScript type checking
36-
console.log("\n📝 Type checking...");
37-
const typecheckResult = await $`bun run typecheck`.nothrow();
38-
if (typecheckResult.exitCode === 0) {
39-
console.log("✓ Type checking passed");
40-
} else {
41-
console.error("✗ Type checking failed");
42-
errors++;
43-
}
44-
45-
// Run tests
46-
console.log("\n🧪 Running tests...");
47-
const testResult = await $`bun test`.nothrow();
48-
if (testResult.exitCode === 0) {
49-
console.log("✓ Tests passed");
50-
} else {
51-
console.error("✗ Tests failed");
52-
errors++;
53-
}
54-
5535
// Run checks
5636
console.log("\n🔧 Checking code quality...");
5737
const checkResult = await $`bun run check`.nothrow();
@@ -64,7 +44,7 @@ if (checkResult.exitCode === 0) {
6444

6545
// Build the plugin
6646
console.log("\n📦 Building plugin...");
67-
const buildResult = await $`bun run build`.nothrow();
47+
const buildResult = await $`bun run build.ts`.nothrow();
6848
if (buildResult.exitCode === 0) {
6949
console.log("✓ Build successful");
7050

version-bump.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ if (!targetVersion) {
99
const manifest = JSON.parse(readFileSync("manifest.json", "utf8"));
1010
const { minAppVersion } = manifest;
1111
manifest.version = targetVersion;
12-
writeFileSync("manifest.json", JSON.stringify(manifest, null, 2));
12+
writeFileSync("manifest.json", `${JSON.stringify(manifest, null, 2)}\n`);
1313

1414
// Update versions.json
1515
const versions = JSON.parse(readFileSync("versions.json", "utf8"));
1616
versions[targetVersion] = minAppVersion;
17-
writeFileSync("versions.json", JSON.stringify(versions, null, 2));
17+
writeFileSync("versions.json", `${JSON.stringify(versions, null, 2)}\n`);
1818

1919
console.log(`Updated to version ${targetVersion}`);

0 commit comments

Comments
 (0)