Add a note in generated configs about compile time :force_ssl config (#5653)

aptinio · web-flow · commit 2196ab57e0a2 · 2023-12-04T11:08:33.000+01:00
diff --git a/installer/templates/phx_single/config/runtime.exs b/installer/templates/phx_single/config/runtime.exs
@@ -74,8 +74,8 @@ if config_env() == :prod do
   # "priv/ssl/server.key". For all supported SSL configuration
   # options, see https://hexdocs.pm/plug/Plug.SSL.html#configure/1
   #
-  # We also recommend setting `force_ssl` in your endpoint, ensuring
-  # no data is ever sent via http, always redirecting to https:
+  # We also recommend setting `force_ssl` in your config/prod.exs,
+  # ensuring no data is ever sent via http, always redirecting to https:
   #
   #     config :<%= @web_app_name %>, <%= @endpoint_module %>,
   #       force_ssl: [hsts: true]
diff --git a/installer/templates/phx_umbrella/apps/app_name_web/config/runtime.exs b/installer/templates/phx_umbrella/apps/app_name_web/config/runtime.exs
@@ -55,8 +55,8 @@ config :<%= @web_app_name %>, <%= @endpoint_module %>,
 # "priv/ssl/server.key". For all supported SSL configuration
 # options, see https://hexdocs.pm/plug/Plug.SSL.html#configure/1
 #
-# We also recommend setting `force_ssl` in your endpoint, ensuring
-# no data is ever sent via http, always redirecting to https:
+# We also recommend setting `force_ssl` in your config/prod.exs,
+# ensuring no data is ever sent via http, always redirecting to https:
 #
 #     config :<%= @web_app_name %>, <%= @endpoint_module %>,
 #       force_ssl: [hsts: true]

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,8 @@ if config_env() == :prod do`
`74`	`74`	`# "priv/ssl/server.key". For all supported SSL configuration`
`75`	`75`	`# options, see https://hexdocs.pm/plug/Plug.SSL.html#configure/1`
`76`	`76`	`#`
`77`		- # We also recommend setting `force_ssl` in your endpoint, ensuring
`78`		`- # no data is ever sent via http, always redirecting to https:`
	`77`	+ # We also recommend setting `force_ssl` in your config/prod.exs,
	`78`	`+ # ensuring no data is ever sent via http, always redirecting to https:`
`79`	`79`	`#`
`80`	`80`	`# config :<%= @web_app_name %>, <%= @endpoint_module %>,`
`81`	`81`	`# force_ssl: [hsts: true]`
Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,8 @@ config :<%= @web_app_name %>, <%= @endpoint_module %>,`
`55`	`55`	`# "priv/ssl/server.key". For all supported SSL configuration`
`56`	`56`	`# options, see https://hexdocs.pm/plug/Plug.SSL.html#configure/1`
`57`	`57`	`#`
`58`		-# We also recommend setting `force_ssl` in your endpoint, ensuring
`59`		`-# no data is ever sent via http, always redirecting to https:`
	`58`	+# We also recommend setting `force_ssl` in your config/prod.exs,
	`59`	`+# ensuring no data is ever sent via http, always redirecting to https:`
`60`	`60`	`#`
`61`	`61`	`# config :<%= @web_app_name %>, <%= @endpoint_module %>,`
`62`	`62`	`# force_ssl: [hsts: true]`