Skip to content

Commit d5021bd

Browse files
committed
minor refactoring
1 parent 94265e3 commit d5021bd

1 file changed

Lines changed: 38 additions & 34 deletions

File tree

lib/phoenix/live_dashboard/info/process_info_component.ex

Lines changed: 38 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -31,44 +31,12 @@ defmodule Phoenix.LiveDashboard.ProcessInfoComponent do
3131
end
3232

3333
@impl true
34-
def render(assigns) do
35-
36-
if process_filter_mod = Application.get_env(:phoenix_live_dashboard, :process_filter, nil) do
37-
filter = assigns.page.params["filter"]
38-
filter && process_filter_mod.render_process_info(assigns, filter) || default_render(assigns)
39-
else
40-
default_render(assigns)
41-
end
42-
43-
end
4434

45-
46-
defp default_render(assigns) do
35+
def render(assigns) do
4736
~H"""
4837
<div class="tabular-info">
4938
<%= if @alive do %>
50-
<Phoenix.LiveDashboard.PageBuilder.label_value_list>
51-
<:elem label="Registered name"><%= @registered_name %></:elem>
52-
<:elem label="Current function"><%= @current_function %></:elem>
53-
<:elem label="Initial call"><%= @initial_call %></:elem>
54-
<:elem label="Status"><%= @status %></:elem>
55-
<:elem label="Message queue length"><%= @message_queue_len %></:elem>
56-
<:elem label="Ancestors"><.info links={@ancestor_links} /></:elem>
57-
<:elem label="Other links"><.info links={@other_links} /></:elem>
58-
<:elem label="Monitors"><.info links={@monitors} /></:elem>
59-
<:elem label="Monitored by"><.info links={@monitored_by} /></:elem>
60-
<:elem label="Trap exit"><%= @trap_exit %></:elem>
61-
<:elem label="Error handler"><%= @error_handler %></:elem>
62-
<:elem label="Priority"><%= @priority %></:elem>
63-
<:elem label="Group leader"><%= @group_leader %></:elem>
64-
<:elem label="Total heap size"><%= @total_heap_size %></:elem>
65-
<:elem label="Heap size"><%= @heap_size %></:elem>
66-
<:elem label="Stack size"><%= @stack_size %></:elem>
67-
<:elem label="Reductions"><%= @reductions %></:elem>
68-
<:elem label="Garbage collection"><%= @garbage_collection %></:elem>
69-
<:elem label="Suspending"><%= @suspending %></:elem>
70-
<:elem label="Current stacktrace"><%= @current_stacktrace %></:elem>
71-
</Phoenix.LiveDashboard.PageBuilder.label_value_list>
39+
<%=process_info_content(assigns) %>
7240
7341
<%= if @page.allow_destructive_actions do %>
7442
<div class="modal-footer">
@@ -82,6 +50,42 @@ defmodule Phoenix.LiveDashboard.ProcessInfoComponent do
8250
"""
8351
end
8452

53+
defp process_info_content(assigns) do
54+
if process_filter_mod = Application.get_env(:phoenix_live_dashboard, :process_filter, nil) do
55+
filter = assigns.page.params["filter"]
56+
filter && process_filter_mod.render_process_info(assigns, filter) || default_process_info_content(assigns)
57+
else
58+
default_process_info_content(assigns)
59+
end
60+
end
61+
62+
def default_process_info_content(assigns) do
63+
~H"""
64+
<Phoenix.LiveDashboard.PageBuilder.label_value_list>
65+
<:elem label="Registered name"><%= @registered_name %></:elem>
66+
<:elem label="Current function"><%= @current_function %></:elem>
67+
<:elem label="Initial call"><%= @initial_call %></:elem>
68+
<:elem label="Status"><%= @status %></:elem>
69+
<:elem label="Message queue length"><%= @message_queue_len %></:elem>
70+
<:elem label="Ancestors"><.info links={@ancestor_links} /></:elem>
71+
<:elem label="Other links"><.info links={@other_links} /></:elem>
72+
<:elem label="Monitors"><.info links={@monitors} /></:elem>
73+
<:elem label="Monitored by"><.info links={@monitored_by} /></:elem>
74+
<:elem label="Trap exit"><%= @trap_exit %></:elem>
75+
<:elem label="Error handler"><%= @error_handler %></:elem>
76+
<:elem label="Priority"><%= @priority %></:elem>
77+
<:elem label="Group leader"><%= @group_leader %></:elem>
78+
<:elem label="Total heap size"><%= @total_heap_size %></:elem>
79+
<:elem label="Heap size"><%= @heap_size %></:elem>
80+
<:elem label="Stack size"><%= @stack_size %></:elem>
81+
<:elem label="Reductions"><%= @reductions %></:elem>
82+
<:elem label="Garbage collection"><%= @garbage_collection %></:elem>
83+
<:elem label="Suspending"><%= @suspending %></:elem>
84+
<:elem label="Current stacktrace"><%= @current_stacktrace %></:elem>
85+
</Phoenix.LiveDashboard.PageBuilder.label_value_list>
86+
"""
87+
end
88+
8589
@impl true
8690
def update(%{id: "PID" <> pid, path: path, return_to: return_to, page: page}, socket) do
8791
pid = :erlang.list_to_pid(String.to_charlist(pid))

0 commit comments

Comments
 (0)