Remove MiniProfiler

phongnguyend · phongnguyend · commit 9002371e14f2 · 2025-03-31T15:57:47.000+07:00
diff --git a/src/Monolith/ClassifiedAds.Infrastructure/ClassifiedAds.Infrastructure.csproj b/src/Monolith/ClassifiedAds.Infrastructure/ClassifiedAds.Infrastructure.csproj
@@ -39,9 +39,6 @@
     <PackageReference Include="Microsoft.Extensions.Logging.AzureAppServices" Version="9.0.1" />
     <PackageReference Include="Microsoft.Extensions.Logging.EventLog" Version="9.0.1" />
     <PackageReference Include="Microsoft.Graph" Version="5.68.0" />
-    <PackageReference Include="MiniProfiler.AspNetCore.Mvc" Version="4.5.4" />
-    <PackageReference Include="MiniProfiler.EntityFrameworkCore" Version="4.5.4" />
-    <PackageReference Include="MiniProfiler.Providers.SqlServer" Version="4.5.4" />
     <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.11.0" />
     <PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="1.11.0" />
     <PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.11.0" />
diff --git a/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MiniProfiler/MiniProfilerOptions.cs b/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MiniProfiler/MiniProfilerOptions.cs
diff --git a/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MiniProfiler/MiniProfilerServiceCollectionExtensions.cs b/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MiniProfiler/MiniProfilerServiceCollectionExtensions.cs
diff --git a/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MonitoringExtensions.cs b/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MonitoringExtensions.cs
@@ -1,7 +1,5 @@
 ﻿using ClassifiedAds.Infrastructure.Monitoring.AzureApplicationInsights;
-using ClassifiedAds.Infrastructure.Monitoring.MiniProfiler;
 using ClassifiedAds.Infrastructure.Monitoring.OpenTelemetry;
-using Microsoft.AspNetCore.Builder;
 using Microsoft.Extensions.DependencyInjection;
 
 namespace ClassifiedAds.Infrastructure.Monitoring;
@@ -10,11 +8,6 @@ public static class MonitoringExtensions
 {
     public static IServiceCollection AddMonitoringServices(this IServiceCollection services, MonitoringOptions monitoringOptions = null)
     {
-        if (monitoringOptions?.MiniProfiler?.IsEnabled ?? false)
-        {
-            services.AddMiniProfiler(monitoringOptions.MiniProfiler);
-        }
-
         if (monitoringOptions?.AzureApplicationInsights?.IsEnabled ?? false)
         {
             services.AddAzureApplicationInsights(monitoringOptions.AzureApplicationInsights);
@@ -27,14 +20,4 @@ public static IServiceCollection AddMonitoringServices(this IServiceCollection s
 
         return services;
     }
-
-    public static IApplicationBuilder UseMonitoringServices(this IApplicationBuilder builder, MonitoringOptions monitoringOptions)
-    {
-        if (monitoringOptions?.MiniProfiler?.IsEnabled ?? false)
-        {
-            builder.UseMiniProfiler();
-        }
-
-        return builder;
-    }
 }
diff --git a/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MonitoringOptions.cs b/src/Monolith/ClassifiedAds.Infrastructure/Monitoring/MonitoringOptions.cs
@@ -1,13 +1,10 @@
 ﻿using ClassifiedAds.Infrastructure.Monitoring.AzureApplicationInsights;
-using ClassifiedAds.Infrastructure.Monitoring.MiniProfiler;
 using ClassifiedAds.Infrastructure.Monitoring.OpenTelemetry;
 
 namespace ClassifiedAds.Infrastructure.Monitoring;
 
 public class MonitoringOptions
 {
-    public MiniProfilerOptions MiniProfiler { get; set; }
-
     public AzureApplicationInsightsOptions AzureApplicationInsights { get; set; }
 
     public OpenTelemetryOptions OpenTelemetry { get; set; }
diff --git a/src/Monolith/ClassifiedAds.Migrator/ClassifiedAds.Migrator.csproj b/src/Monolith/ClassifiedAds.Migrator/ClassifiedAds.Migrator.csproj
@@ -8,7 +8,6 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <EmbeddedResource Include="DbUp\MiniProfiler\0001-CreateTables.sql" />
     <EmbeddedResource Include="DbUp\SqlServerDistributedCache\0001-CreateTables.sql" />
   </ItemGroup>
 
diff --git a/src/Monolith/ClassifiedAds.Migrator/DbUp/MiniProfiler/0001-CreateTables.sql b/src/Monolith/ClassifiedAds.Migrator/DbUp/MiniProfiler/0001-CreateTables.sql
diff --git a/src/Monolith/ClassifiedAds.WebAPI/Program.cs b/src/Monolith/ClassifiedAds.WebAPI/Program.cs
@@ -299,8 +299,6 @@
 
 app.UseRateLimiter();
 
-app.UseMonitoringServices(appSettings.Monitoring);
-
 app.UseHealthChecks("/healthz", new HealthCheckOptions
 {
     Predicate = _ => true,
diff --git a/src/Monolith/ClassifiedAds.WebAPI/appsettings.json b/src/Monolith/ClassifiedAds.WebAPI/appsettings.json
@@ -71,15 +71,6 @@
     }
   },
   "Monitoring": {
-    "MiniProfiler": {
-      "IsEnabled": true
-      //"SqlServerStorage": {
-      //  "ConectionString": "Server=127.0.0.1;Database=ClassifiedAds;User Id=sa;Password=sqladmin123!@#;MultipleActiveResultSets=true",
-      //  "ProfilersTable": "MiniProfilers",
-      //  "TimingsTable": "MiniProfilerTimings",
-      //  "ClientTimingsTable": "MiniProfilerClientTimings"
-      //}
-    },
     "AzureApplicationInsights": {
       "IsEnabled": false,
       "InstrumentationKey": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
diff --git a/src/Monolith/ClassifiedAds.WebMVC/HttpMessageHandlers/ProfilingHttpHandler.cs b/src/Monolith/ClassifiedAds.WebMVC/HttpMessageHandlers/ProfilingHttpHandler.cs
diff --git a/src/Monolith/ClassifiedAds.WebMVC/Program.cs b/src/Monolith/ClassifiedAds.WebMVC/Program.cs
@@ -130,10 +130,8 @@
 })
 .AddSingleton<IAuthorizationHandler, CustomRequirementHandler>();
 
-services.AddTransient<ProfilingHttpHandler>();
 services.AddTransient<BearerTokenHandler>();
 services.AddHttpClient(string.Empty)
-        .AddHttpMessageHandler<ProfilingHttpHandler>()
         .AddHttpMessageHandler<BearerTokenHandler>();
 
 services.AddCaches(appSettings.Caching);
@@ -196,8 +194,6 @@
 app.UseAuthentication();
 app.UseAuthorization();
 
-app.UseMonitoringServices(appSettings.Monitoring);
-
 app.UseHealthChecks("/healthz", new HealthCheckOptions
 {
     Predicate = _ => true,
diff --git a/src/Monolith/ClassifiedAds.WebMVC/Views/Shared/_Layout.cshtml b/src/Monolith/ClassifiedAds.WebMVC/Views/Shared/_Layout.cshtml
@@ -64,9 +64,6 @@
                                 <a class="nav-link text-dark" href="/healthz">Health Checks</a>
                             </li>
                         </feature>
-                        <li class="nav-item">
-                            <a class="nav-link text-dark" href="@appSettings.Value.ResourceServer.PublicEndpoint/profiler/results">API</a>
-                        </li>
                     </ul>
                 </div>
             </div>
@@ -84,7 +81,6 @@
             &copy; 2020 - ClassifiedAds.WebMVC - <a asp-area="" asp-controller="Home" asp-action="Privacy">Privacy</a>
         </div>
     </footer>
-    <mini-profiler />
     <environment include="Development">
         <script src="~/lib/jquery/dist/jquery.js"></script>
         <script src="~/lib/bootstrap/dist/js/bootstrap.bundle.js"></script>
diff --git a/src/Monolith/ClassifiedAds.WebMVC/Views/_ViewImports.cshtml b/src/Monolith/ClassifiedAds.WebMVC/Views/_ViewImports.cshtml
@@ -1,8 +1,4 @@
 ﻿@using ClassifiedAds.WebMVC
 @using ClassifiedAds.WebMVC.Models
 @addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers
-
 @addTagHelper *, Microsoft.FeatureManagement.AspNetCore
-
-@using StackExchange.Profiling
-@addTagHelper *, MiniProfiler.AspNetCore.Mvc
diff --git a/src/Monolith/ClassifiedAds.WebMVC/appsettings.json b/src/Monolith/ClassifiedAds.WebMVC/appsettings.json
@@ -75,9 +75,6 @@
     }
   },
   "Monitoring": {
-    "MiniProfiler": {
-      "IsEnabled": true
-    },
     "AzureApplicationInsights": {
       "IsEnabled": false
     },

Original file line number	Diff line number	Diff line change
`@@ -299,8 +299,6 @@`
`299`	`299`
`300`	`300`	`app.UseRateLimiter();`
`301`	`301`
`302`		`-app.UseMonitoringServices(appSettings.Monitoring);`
`303`		`-`
`304`	`302`	`app.UseHealthChecks("/healthz", new HealthCheckOptions`
`305`	`303`	`{`
`306`	`304`	`Predicate = _ => true,`