Skip to content

Commit ece4377

Browse files
committed
refactor: remove support for extra artifacts in build process
This commit removes the `extra-artifacts` input and related logic from the build-makefile-dylib action and the makefile-dylib-release workflow. The changes streamline the release process by eliminating unnecessary complexity associated with handling additional build outputs.
1 parent 74fba4a commit ece4377

2 files changed

Lines changed: 0 additions & 34 deletions

File tree

.github/blocks/build-makefile-dylib/action.yml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ inputs:
99
required: false
1010
default: ''
1111
description: "Version to embed (passed as VERSION= to make)"
12-
extra-artifacts:
13-
required: false
14-
default: ''
15-
description: "Newline-separated list of additional build outputs (paths relative to repo root) to attach to the release. Each path is copied into artifacts/ alongside the dylib."
1612

1713
runs:
1814
using: "composite"
@@ -36,30 +32,6 @@ runs:
3632
3733
- name: Prepare artifact
3834
shell: bash
39-
env:
40-
EXTRA_ARTIFACTS: ${{ inputs.extra-artifacts }}
4135
run: |
4236
mkdir -p artifacts
4337
cp "build/${{ inputs.output-name }}.dylib" artifacts/
44-
45-
if [ -n "$EXTRA_ARTIFACTS" ]; then
46-
while IFS= read -r raw; do
47-
# strip leading/trailing whitespace
48-
extra="${raw#"${raw%%[![:space:]]*}"}"
49-
extra="${extra%"${extra##*[![:space:]]}"}"
50-
51-
# skip blank lines and comments
52-
if [ -z "$extra" ] || [ "${extra#\#}" != "$extra" ]; then
53-
continue
54-
fi
55-
56-
if [ ! -f "$extra" ]; then
57-
echo "::error::extra artifact '$extra' not found — build failure"
58-
exit 1
59-
fi
60-
61-
echo "Including extra artifact: $extra"
62-
file "$extra"
63-
cp "$extra" artifacts/
64-
done <<< "$EXTRA_ARTIFACTS"
65-
fi

.github/workflows/makefile-dylib-release.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,6 @@ on:
1111
required: false
1212
default: false
1313
description: "Opt in to Blacksmith Linux runners (blacksmith-4vcpu-ubuntu-2404). Requires the Blacksmith GitHub App installed on the caller org. Defaults to ubuntu-latest."
14-
extra-artifacts:
15-
type: string
16-
required: false
17-
default: ''
18-
description: "Newline-separated list of extra build outputs (relative to repo root) to attach to the release alongside the dylib."
1914
secrets:
2015
OPENAI_API_KEY:
2116
required: true
@@ -65,7 +60,6 @@ jobs:
6560
with:
6661
output-name: ${{ inputs.dylib-name }}
6762
version: ${{ needs.prepare-release.outputs.version }}
68-
extra-artifacts: ${{ inputs.extra-artifacts }}
6963
- uses: actions/upload-artifact@v4
7064
with:
7165
name: ${{ inputs.dylib-name }}

0 commit comments

Comments
 (0)