Merge pull request #6 from boekkooi/expire-cleanup

Remove the cache file when a expire item was required

Author: Nyholm

src/FilesystemCachePool.php

@@ -46,6 +46,8 @@ protected function fetchObjectFromCache($key)
 
         $data = unserialize($this->filesystem->read($file));
         if ($data[0] !== null && time() > $data[0]) {
+            $this->clearOneObjectFromCache($key);
+
             return [false, null];
         }
 

tests/FilesystemCachePoolTest.php

@@ -27,4 +27,21 @@ public function testInvalidKey()
 
         $pool->getItem('test%string')->get();
     }
+
+    public function testCleanupOnExpire()
+    {
+        $pool = $this->createCachePool();
+
+        $item = $pool->getItem('test_ttl_null');
+        $item->set('data');
+        $item->expiresAt(new \DateTime('now'));
+        $pool->save($item);
+        $this->assertTrue($this->getFilesystem()->has('cache/test_ttl_null'));
+
+        sleep(1);
+
+        $item = $pool->getItem('test_ttl_null');
+        $this->assertFalse($item->isHit());
+        $this->assertFalse($this->getFilesystem()->has('cache/test_ttl_null'));
+    }
 }