Open
Description
While thinkering with the site, I've found a bug in markdown rendering: top level titles (AKA <h1>
) are rendered at the HTML level, but are not visible:
Compare:
- https://www.php-fig.org/bylaws/mission-and-structure/
- https://github.com/php-fig/fig-standards/blob/master/bylaws/001-mission-and-structure.md
The Structure
top title is not shown:
But it's present in HTML:
Maybe it's a CSS issue?
Activity
stefanotorresi commentedon Feb 19, 2019
I think this was done by design by @reinink, see
www.php-fig.org/source/_sass/blocks/markdown.scss
Lines 8 to 14 in 54e3d54
that said, I think we can easily reinstate them by adding some coherent styiling.
Jean85 commentedon Feb 19, 2019
Reinstating them would create duplication between the green band with the title and the beige part with the parsed markdown document. Maybe we can disable the
h1
only if it's the first thing inside the parsed body?Jean85 commentedon Feb 19, 2019
I did it and it works, but the
h1
are not styled at all! 😄I'll try to add some rules...
vdelau commentedon Jul 13, 2021
I think we need to fix this. The most important place where I feel duplication of headers is weird, is in the PSR documents and the personnel which are included from fig-standards.
I'm wondering if we can somehow expose the post type as a class somewhere in the page (body, markdown container), so we can do something like
.post_type_psr .markdown h1:first-of-type {display: none;}