From 77c0b71d0548ad17c416274ec18275e2eb26d7ea Mon Sep 17 00:00:00 2001 From: "Eirik S. Morland" Date: Mon, 23 Sep 2024 10:23:26 +0200 Subject: [PATCH 1/3] Fix implicit nullable type to avoid PHP 8.4 warnings --- src/HttpMethodsClient.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/HttpMethodsClient.php b/src/HttpMethodsClient.php index 497921b..95fee3b 100644 --- a/src/HttpMethodsClient.php +++ b/src/HttpMethodsClient.php @@ -33,7 +33,7 @@ final class HttpMethodsClient implements HttpMethodsClientInterface /** * @param RequestFactory|RequestFactoryInterface $requestFactory */ - public function __construct(ClientInterface $httpClient, $requestFactory, StreamFactoryInterface $streamFactory = null) + public function __construct(ClientInterface $httpClient, $requestFactory, ?StreamFactoryInterface $streamFactory = null) { if (!$requestFactory instanceof RequestFactory && !$requestFactory instanceof RequestFactoryInterface) { throw new \TypeError( From 12bd68fc703ca9612ba62bcbc8bccc50e1a0dbee Mon Sep 17 00:00:00 2001 From: Eirik Stanghelle Morland Date: Mon, 23 Sep 2024 10:47:37 +0200 Subject: [PATCH 2/3] Add 8.4 to matrix --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5c51567..aff38a1 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - php: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + php: ['7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] steps: - name: Checkout code From d6a41105bbe74f0fc4d03547f5c60d616e4fb85a Mon Sep 17 00:00:00 2001 From: Eirik Stanghelle Morland Date: Mon, 23 Sep 2024 11:30:16 +0200 Subject: [PATCH 3/3] Update tests.yml --- .github/workflows/tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index aff38a1..145d475 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -25,6 +25,10 @@ jobs: tools: composer:v2 coverage: none + - name: Emulate PHP 8.3 + run: composer config platform.php 8.3.999 + if: matrix.php == '8.4' + - name: Install PHP dependencies run: composer update --prefer-dist --no-interaction --no-progress