Skip to content
This repository was archived by the owner on May 13, 2023. It is now read-only.
This repository was archived by the owner on May 13, 2023. It is now read-only.

Test on PHP 8 #41

Open
Open
@GrahamCampbell

Description

@GrahamCampbell

There is no upper bound on the PHP version (and too late to add one in 1.x). We should test on PHP 8.0 with the CI.

Activity

dbu

dbu commented on Jul 6, 2020

@dbu
Contributor

i wonder if we don't want to add the upper bound anyways. then at least in the future, we are more robust.

GrahamCampbell

GrahamCampbell commented on Jul 6, 2020

@GrahamCampbell
Author

An upperbound would be a good idea, because almost certainly PHP 9 will have totally deleted the concept of a resource, so things like https://github.com/php-http/message-factory/blob/master/src/StreamFactory.php#L17 need updating with whatever the replacement for fopen's return type is, and related types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dbu@GrahamCampbell

        Issue actions

          Test on PHP 8 · Issue #41 · php-http/message-factory