Skip to content

Composer install #156

Open
Open
@mikeymike

Description

@AydinHassan wanted to get your thoughts on this 😄

Currently we run a composer install on the solution files but we only do this if the composer.lock file is present.

Currently learnyouphp Dependency Heaven exercise is broken because of a library update where they changed the casing in the output.

The quick solution would be to update the dependencies in leanyouphp but this may become a wider issue with minor version increments. Instead I'm thinking we drop the composer.lock file from solutions, much like the concept behind doing this with libraries so that we're not forcing a single version but install the latest available at the time (meeting requirements ofc).

So instead of checking for the existance of the lock file before running the composer install command we just check for the json file. Then in learnyouphp we can just drop the lock file and problem solved.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions