Move tests to appropriate suites (#38)

Author: NickSdot

tests/Unit/Runner/XmlFileProcessorPipelineTest.php

@@ -72,6 +72,52 @@ public function itAppliesFixesToTheOriginalSourceWhenEntitiesExpandBeforeTheViol
         }
     }
 
+    #[Test] // TODO: should be integration
+    public function itHandlesEntitiesWithoutParseErrors(): void
+    {
+        $xml = $this->xml(
+            '<!DOCTYPE chapter SYSTEM "docbook.dtd">
+        <chapter>
+          <simpara>&link.superglobals; &php.ini; &amp;</simpara>
+        </chapter>'
+        );
+
+        $processor = $this->processor([], new EntityPreprocessor([
+            'link.superglobals' => '',
+            'php.ini' => '',
+        ]));
+
+        $report = $this->process($processor, $xml);
+
+        self::assertCount(
+            0,
+            array_filter(
+                $report->getViolations(),
+                fn($v) => $v->sniffCode === 'DocbookCS.Internal'
+            )
+        );
+    }
+
+    #[Test] // TODO: should be integration
+    public function itUsesCustomPreprocessor(): void
+    {
+        $processor = $this->processor([], new EntityPreprocessor([
+            'custom.entity' => '[X]',
+        ]));
+
+        $xml = $this->xml('<chapter><simpara>&custom.entity;</simpara></chapter>');
+
+        $report = $this->process($processor, $xml);
+
+        self::assertCount(
+            0,
+            array_filter(
+                $report->getViolations(),
+                fn($v) => $v->sniffCode === 'DocbookCS.Internal'
+            )
+        );
+    }
+
     private function process(XmlFileProcessor $processor, string $content, string $path = 'input.xml'): FileReport
     {
         return $processor->process(new File($path, $content))->fileReport;
@@ -90,6 +136,14 @@ private function processFile(XmlFileProcessor $processor, string $path): FileRep
         return $result->fileReport;
     }
 
+    private function xml(string $body): string
+    {
+        return <<<XML
+<?xml version="1.0" encoding="UTF-8"?>
+$body
+XML;
+    }
+
     /** @param list<SniffInterface> $sniffs */
     private function processor(array $sniffs = [], ?EntityPreprocessor $pre = null): XmlFileProcessor
     {

tests/Unit/Runner/XmlFileProcessorTest.php

@@ -87,52 +87,6 @@ public function itAcceptsValidXmlWithoutViolations(): void
         self::assertFalse($report->hasViolations());
     }
 
-    #[Test] // TODO: should be integration
-    public function itHandlesEntitiesWithoutParseErrors(): void
-    {
-        $xml = $this->xml(
-            '<!DOCTYPE chapter SYSTEM "docbook.dtd">
-        <chapter>
-          <simpara>&link.superglobals; &php.ini; &amp;</simpara>
-        </chapter>'
-        );
-
-        $processor = $this->processor([], new EntityPreprocessor([
-            'link.superglobals' => '',
-            'php.ini' => '',
-        ]));
-
-        $report = $this->process($processor, $xml);
-
-        self::assertCount(
-            0,
-            array_filter(
-                $report->getViolations(),
-                fn($v) => $v->sniffCode === 'DocbookCS.Internal'
-            )
-        );
-    }
-
-    #[Test] // TODO: should be integration
-    public function itUsesCustomPreprocessor(): void
-    {
-        $processor = $this->processor([], new EntityPreprocessor([
-            'custom.entity' => '[X]',
-        ]));
-
-        $xml = $this->xml('<chapter><simpara>&custom.entity;</simpara></chapter>');
-
-        $report = $this->process($processor, $xml);
-
-        self::assertCount(
-            0,
-            array_filter(
-                $report->getViolations(),
-                fn($v) => $v->sniffCode === 'DocbookCS.Internal'
-            )
-        );
-    }
-
     #[Test]
     public function itReturnsZeroViolationsWithoutSniffs(): void
     {