Skip to content

Commit c2aab04

Browse files
committed
explicitly utf8 no bom
1 parent 158c689 commit c2aab04

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

.github/workflows/windows.yaml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -147,17 +147,17 @@ jobs:
147147
run: |
148148
go install github.com/josephspurrier/goversioninfo/cmd/goversioninfo@latest
149149
150-
$maj = 0; $min = 0; $pat = 0; $bld = 0
151-
if ($env:FRANKENPHP_VERSION -match '^(?<M>\d+)\.(?<m>\d+)\.(?<p>\d+)$') {
152-
$maj = [int]$Matches['M']
153-
$min = [int]$Matches['m']
154-
$pat = [int]$Matches['p']
150+
$major = 0; $minor = 0; $patch = 0; $bld = 0
151+
if ($env:FRANKENPHP_VERSION -match '^(?<major>\d+)\.(?<minor>\d+)\.(?<patch>\d+)$') {
152+
$major = [int]$Matches['major']
153+
$minor = [int]$Matches['minor']
154+
$patch = [int]$Matches['patch']
155155
}
156156
157157
$json = @{
158158
FixedFileInfo = @{
159-
FileVersion = @{ Major = $maj; Minor = $min; Patch = $pat; Build = $bld }
160-
ProductVersion = @{ Major = $maj; Minor = $min; Patch = $pat; Build = $bld }
159+
FileVersion = @{ Major = $major; Minor = $minor; Patch = $patch; Build = $bld }
160+
ProductVersion = @{ Major = $major; Minor = $minor; Patch = $patch; Build = $bld }
161161
}
162162
StringFileInfo = @{
163163
CompanyName = "FrankenPHP"
@@ -171,10 +171,11 @@ jobs:
171171
Comments = "https://frankenphp.dev/"
172172
}
173173
VarFileInfo = @{
174-
Translation = @{ LangID = 1033; CharsetID = 1200 }
174+
Translation = @{ LangID = 9; CharsetID = 1200 }
175175
}
176176
} | ConvertTo-Json -Depth 10
177-
[System.IO.File]::WriteAllText("versioninfo.json", $json)
177+
$Utf8NoBom = New-Object System.Text.UTF8Encoding($false)
178+
[System.IO.File]::WriteAllText("versioninfo.json", $json, $Utf8NoBom)
178179
179180
goversioninfo -64 -icon ..\..\frankenphp.ico versioninfo.json -o resource.syso
180181

0 commit comments

Comments
 (0)