Fixing new static analysis updates

Author: asgrim

phpstan-baseline.neon

@@ -1,11 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: '#^Call to function is_string\(\) with non\-empty\-string will always evaluate to true\.$#'
-			identifier: function.alreadyNarrowedType
-			count: 1
-			path: src/Command/CommandHelper.php
-
 		-
 			message: '#^Cannot cast mixed to int\.$#'
 			identifier: cast.int
@@ -60,18 +54,6 @@ parameters:
 			count: 1
 			path: src/ComposerIntegration/PieComposerInstaller.php
 
-		-
-			message: '#^Call to function assert\(\) with true will always evaluate to true\.$#'
-			identifier: function.alreadyNarrowedType
-			count: 1
-			path: src/ComposerIntegration/QuieterConsoleIO.php
-
-		-
-			message: '#^Strict comparison using \!\=\= between Closure\(Composer\\IO\\ConsoleIO\)\: void and null will always evaluate to true\.$#'
-			identifier: notIdentical.alwaysTrue
-			count: 1
-			path: src/ComposerIntegration/QuieterConsoleIO.php
-
 		-
 			message: '#^Cannot cast mixed to string\.$#'
 			identifier: cast.string

src/SelfManage/BuildTools/BinaryBuildToolFinder.php

@@ -9,7 +9,6 @@
 use Symfony\Component\Process\ExecutableFinder;
 
 use function array_key_exists;
-use function assert;
 use function implode;
 use function is_array;
 use function Safe\preg_replace;
@@ -54,10 +53,7 @@ public function packageNameFor(PackageManager $packageManager, TargetPlatform $t
         }
 
         if ($this->packageManagerPackages[$packageManager->value] === '{php-config-path}') {
-            $phpConfigPath = preg_replace('((.*)php)', '$1php-config', $targetPlatform->phpBinaryPath->phpBinaryPath);
-            assert($phpConfigPath !== '');
-
-            return $phpConfigPath;
+            return preg_replace('((.*)php)', '$1php-config', $targetPlatform->phpBinaryPath->phpBinaryPath);
         }
 
         // If we need to customise specific package names depending on OS