fix: Json output without errors (#475)

* fix json empty errors output

* Add test for JSON output with no errors in CheckCommand

This test ensures that the JSON output format properly handles and displays an empty result when no errors are present. It validates the success of the command and confirms the output is in valid JSON format with the expected structure.

Author: raffaelecarelle

src/CLI/Command/Check.php

@@ -200,7 +200,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return self::ERROR_CODE;
         }
 
-        $this->printNoViolationsDetectedMessage($output, $onlyErrors);
+        $this->printNoViolationsDetectedMessage($output, $onlyErrors, $format);
 
         if (!$onlyErrors) {
             $this->printExecutionTime($output, $startTime);
@@ -266,6 +266,7 @@ private function printViolations(Violations $violations, OutputInterface $output
         if (!$onlyErrors) {
             $output->writeln('<error>ERRORS!</error>');
         }
+
         $output->writeln(sprintf('%s', $violations->toString($format)));
         if (!$onlyErrors) {
             $output->writeln(sprintf('<error>%s VIOLATIONS DETECTED!</error>', \count($violations)));
@@ -280,10 +281,12 @@ private function printParsedErrors(ParsingErrors $parsingErrors, OutputInterface
         $output->writeln(sprintf('%s', $parsingErrors->toString()));
     }
 
-    private function printNoViolationsDetectedMessage(OutputInterface $output, bool $onlyErrors = false): void
+    private function printNoViolationsDetectedMessage(OutputInterface $output, bool $onlyErrors = false, string $format = Printer::FORMAT_TEXT): void
     {
         if (!$onlyErrors) {
             $output->writeln('<info>NO VIOLATIONS DETECTED!</info>');
+        } elseif (Printer::FORMAT_JSON === $format) {
+            $output->writeln('<info>[]</info>');
         }
     }
 }

tests/E2E/Cli/CheckCommandTest.php

@@ -179,6 +179,22 @@ public function test_json_format_output(): void
         $this->assertJson($display);
     }
 
+    public function test_json_format_output_no_errors(): void
+    {
+        $configFilePath = __DIR__.'/../_fixtures/configMvcWithoutErrors.php';
+
+        $cmdTester = $this->runCheck($configFilePath, null, null, false, false, false, 'json');
+
+        $this->assertCheckHasSuccess($cmdTester);
+
+        $display = $cmdTester->getDisplay();
+
+        $this->assertJson($display);
+
+        $json = json_decode($display, true);
+        $this->assertCount(0, $json);
+    }
+
     protected function runCheck(
         $configFilePath = null,
         ?bool $stopOnFailure = null,