fix: break after finding ini comment (#536)

pixeldrift64 · web-flow · commit e7c5e62326d7 · 2026-07-27T16:29:34.000+01:00
* fix: break after finding ini comment

* tweak: added test
diff --git a/src/CommentIni.php b/src/CommentIni.php
@@ -70,6 +70,7 @@ private function findIniComment(iterable $walker):array {
 
 			$this->assertCommentIsLeadingNode($commentNode);
 			$commentNodeToRemove = $commentNode;
+			break;
 		}
 
 		return [$commentNodeToRemove, $ini];
diff --git a/test/phpunit/CommentIniTest.php b/test/phpunit/CommentIniTest.php
@@ -35,6 +35,13 @@ public function testContainsIniData_emptyIfMalformedIniSyntax():void {
 		self::assertStringContainsString("something: broken", $document->saveHTML());
 	}
 
+	public function testContainsIniData_onlyFindsFirstComment():void {
+		$document = new HTMLDocument(HTMLPageContent::HTML_COMMENT_WITH_INI_AND_ANOTHER_COMMENT);
+		$sut = new CommentIni($document);
+		self::assertTrue($sut->containsIniData());
+		self::assertEquals("base-page", $sut->get("extends"));
+	}
+
 	public function testGet_noMatchingData():void {
 		$document = new HTMLDocument(HTMLPageContent::HTML_EXTENDS_PARTIAL_VIEW);
 		$sut = new CommentIni($document);
diff --git a/test/phpunit/TestHelper/HTMLPageContent.php b/test/phpunit/TestHelper/HTMLPageContent.php
@@ -934,6 +934,16 @@ class HTMLPageContent {
 <article>
 	<h1>Hello from within a sub-template!</h1>
 </article>
+HTML;
+
+	const HTML_COMMENT_WITH_INI_AND_ANOTHER_COMMENT = <<<HTML
+<!-- 
+extends=base-page
+-->
+<article>
+	<!-- This is just another comment -->
+	<h1>Hello from within a sub-template!</h1>
+</article>
 HTML;
 
 	const HTML_COMPONENT = <<<HTML

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ private function findIniComment(iterable $walker):array {`
`70`	`70`
`71`	`71`	`$this->assertCommentIsLeadingNode($commentNode);`
`72`	`72`	`$commentNodeToRemove = $commentNode;`
	`73`	`+ break;`
`73`	`74`	`}`
`74`	`75`
`75`	`76`	`return [$commentNodeToRemove, $ini];`