maintenance: phpstan type safety

Author: g105b

src/Path/DynamicPath.php

@@ -48,6 +48,10 @@ public function get(?string $key = null, bool $extra = false):?string {
 		return null;
 	}
 
+	/**
+	 * @param array<string> $filePathParts
+	 * @param array<string> $requestPathParts
+	 */
 	private function handleNullKey(
 		array $filePathParts,
 		array $requestPathParts,
@@ -60,7 +64,14 @@ private function handleNullKey(
 		return $requestPathParts[count($filePathParts) - 1] ?? null;
 	}
 
-	private function getExtraPath(array $filePathParts, array $requestPathParts):string {
+	/**
+	 * @param array<string> $filePathParts
+	 * @param array<string> $requestPathParts
+	 */
+	private function getExtraPath(
+		array $filePathParts,
+		array $requestPathParts,
+	):string {
 		$test = "";
 		for($ppi = count($filePathParts), $len = count($requestPathParts); $ppi < $len; $ppi++) {
 			$test .= $requestPathParts[$ppi] . "/";
@@ -72,7 +83,11 @@ private function matchesKey(string $placeholder, string $key):bool {
 		return ltrim($placeholder, "@") === $key;
 	}
 
-	private function getMatchedKey(array $requestPathParts, int $index):?string {
+	/** @param array<string> $requestPathParts */
+	private function getMatchedKey(
+		array $requestPathParts,
+		int $index,
+	):?string {
 		return $requestPathParts[$index] ?? null;
 	}
 

src/RouterCallback.php

@@ -50,17 +50,26 @@ public function isAllowedMethod(string $requestMethod):bool {
 		return $this->isMethodAllowed($requestMethod, $allowedMethods);
 	}
 
-	private function getAllowedMethods(): array {
+	/** @return array<string> */
+	private function getAllowedMethods():array {
 		$methodsArgument = $this->attribute->getArguments()["methods"] ?? [];
 		return $this->mapAttributeToMethods($this->attribute->getName(), $methodsArgument);
 	}
 
-	private function mapAttributeToMethods(string $attributeName, array $methodsArgument): array {
+	/**
+	 * @param array<string> $methodsArgument
+	 * @return array<string>
+	 */
+	private function mapAttributeToMethods(
+		string $attributeName,
+		array $methodsArgument,
+	):array {
 		$attributeMethodMap = $this->getAttributeMethodMap();
 		return $attributeMethodMap[$attributeName] ?? $methodsArgument;
 	}
 
-	private function getAttributeMethodMap(): array {
+	/** @return array<class-string, array<string>> */
+	private function getAttributeMethodMap():array {
 		return [
 			Any::class => HttpRoute::METHODS_ALL,
 			Connect::class => [HttpRoute::METHOD_CONNECT],
@@ -75,11 +84,21 @@ private function getAttributeMethodMap(): array {
 		];
 	}
 
-	private function normalizeMethods(array $methods): array {
+	/**
+	 * @param array<string> $methods
+	 * @return array<string>
+	 */
+	private function normalizeMethods(array $methods):array {
 		return array_map("strtoupper", $methods);
 	}
 
-	private function isMethodAllowed(string $requestMethod, array $allowedMethods): bool {
+	/**
+	 * @param array<string> $allowedMethods
+	 */
+	private function isMethodAllowed(
+		string $requestMethod,
+		array $allowedMethods,
+	):bool {
 		return in_array(strtoupper($requestMethod), $allowedMethods, true);
 	}