Do not report private services in test container

Author: lookyman

src/Rules/Symfony/ContainerInterfacePrivateServiceRule.php

@@ -43,7 +43,8 @@ public function processNode(Node $node, Scope $scope): array
 		$argType = $scope->getType($node->var);
 		$isControllerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Controller\Controller'))->isSuperTypeOf($argType);
 		$isContainerType = (new ObjectType('Symfony\Component\DependencyInjection\ContainerInterface'))->isSuperTypeOf($argType);
-		if (!$isControllerType->yes() && !$isContainerType->yes()) {
+		$isTestContainerType = (new ObjectType('Symfony\Bundle\FrameworkBundle\Test\TestContainer'))->isSuperTypeOf($argType);
+		if ($isTestContainerType->yes() || (!$isControllerType->yes() && !$isContainerType->yes())) {
 			return [];
 		}
 

tests/Rules/Symfony/ContainerInterfacePrivateServiceRuleTest.php

@@ -22,7 +22,7 @@ public function testGetPrivateService(): void
 			[
 				[
 					'Service "private" is private.',
-					14,
+					15,
 				],
 			]
 		);

tests/Rules/Symfony/ContainerInterfaceUnknownServiceRuleTest.php

@@ -22,19 +22,19 @@ public function testGetUnknownService(): void
 			[
 				[
 					'Service "service.not.found" is not registered in the container.',
-					20,
+					21,
 				],
 				[
 					'Service "PHPStan\Symfony\ServiceMap" is not registered in the container.',
-					26,
+					27,
 				],
 				[
 					'Service "service.PHPStan\Symfony\ServiceMap" is not registered in the container.',
-					38,
+					39,
 				],
 				[
 					'Service "PHPStan\Symfony\ExampleController" is not registered in the container.',
-					44,
+					45,
 				],
 			]
 		);

tests/Symfony/ServiceMapTest.php

@@ -41,7 +41,7 @@ public function testGetServiceIdFromNode(): void
 		$broker = $this->createBroker();
 		$printer = new Standard();
 		$typeSpecifier = $this->createTypeSpecifier($printer, $broker);
-		$scope = new Scope($broker, $printer, $typeSpecifier, ScopeContext::create(''));
+		$scope = new Scope($this->createScopeFactory($broker, $typeSpecifier), $broker, $printer, $typeSpecifier, ScopeContext::create(''));
 
 		self::assertSame('foo', ServiceMap::getServiceIdFromNode(new String_('foo'), $scope));
 		self::assertSame('bar', ServiceMap::getServiceIdFromNode(new ClassConstFetch(new Name(ExampleController::class), 'BAR'), $scope));

tests/Symfony/data/ExampleController.php

@@ -3,6 +3,7 @@
 namespace PHPStan\Symfony;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
+use Symfony\Bundle\FrameworkBundle\Test\TestContainer;
 
 final class ExampleController extends Controller
 {
@@ -45,4 +46,14 @@ public function getSelfService(): void
 		$service->noMethod();
 	}
 
+	public function testContainer(): void
+	{
+		$service = $this->getTestContainer()->get('private');
+		$service->noMethod();
+	}
+
+	private function getTestContainer(): TestContainer
+	{
+	}
+
 }