Remove nullable type after calling HeaderBag::has

Author: franmomu

extension.neon

@@ -298,5 +298,14 @@ services:
 
 	# InputBag::get() type specification
 	-
-		factory: PHPStan\Type\Symfony\InputBagTypeSpecifyingExtension
+		factory: PHPStan\Type\Symfony\BagTypeSpecifyingExtension
 		tags: [phpstan.typeSpecifier.methodTypeSpecifyingExtension]
+		arguments:
+		    className: Symfony\Component\HttpFoundation\InputBag
+
+	# HeaderBag::get() type specification
+	-
+		factory: PHPStan\Type\Symfony\BagTypeSpecifyingExtension
+		tags: [phpstan.typeSpecifier.methodTypeSpecifyingExtension]
+		arguments:
+		    className: Symfony\Component\HttpFoundation\HeaderBag

src/Type/Symfony/InputBagTypeSpecifyingExtension.php src/Type/Symfony/BagTypeSpecifyingExtension.php

@@ -11,21 +11,30 @@
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\MethodTypeSpecifyingExtension;
 use PHPStan\Type\NullType;
-use Symfony\Component\HttpFoundation\InputBag;
 
-final class InputBagTypeSpecifyingExtension implements MethodTypeSpecifyingExtension, TypeSpecifierAwareExtension
+final class BagTypeSpecifyingExtension implements MethodTypeSpecifyingExtension, TypeSpecifierAwareExtension
 {
 
-	private const INPUT_BAG_CLASS = InputBag::class;
 	private const HAS_METHOD_NAME = 'has';
 	private const GET_METHOD_NAME = 'get';
 
 	/** @var TypeSpecifier */
 	private $typeSpecifier;
 
+	/** @var class-string */
+	private $className;
+
+	/**
+	 * @param class-string $className
+	 */
+	public function __construct(string $className)
+	{
+		$this->className = $className;
+	}
+
 	public function getClass(): string
 	{
-		return self::INPUT_BAG_CLASS;
+		return $this->className;
 	}
 
 	public function isMethodSupported(MethodReflection $methodReflection, MethodCall $node, TypeSpecifierContext $context): bool

tests/Type/Symfony/ExtensionTest.php

@@ -15,7 +15,7 @@ class ExtensionTest extends TypeInferenceTestCase
 	public function dataFileAsserts(): iterable
 	{
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/envelope_all.php');
-		yield from $this->gatherAssertTypes(__DIR__ . '/data/header_bag_get.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/header_bag.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/response_header_bag_get_cookies.php');
 
 		if (class_exists('Symfony\Component\HttpFoundation\InputBag')) {

tests/Type/Symfony/data/header_bag_get.php tests/Type/Symfony/data/header_bag.php

@@ -4,6 +4,12 @@
 
 $bag = new \Symfony\Component\HttpFoundation\HeaderBag(['foo' => ['bar']]);
 
+if ($bag->has('bar')) {
+	assertType('string', $bag->get('bar'));
+} else {
+	assertType('null', $bag->get('bar'));
+}
+
 assertType('string|null', $bag->get('foo'));
 assertType('string|null', $bag->get('foo', null));
 assertType('string', $bag->get('foo', 'baz'));