Cloud

[phuchoang2603]

No description provided.

[Copilot]

Pull Request Overview

This PR refactors the Argo CD “App of Apps” chart to introduce a new cloud deployment mode (alongside existing proxmox), embeds all cloud-specific manifests (IngressRoutes, certificates, issuers), adds finalizers to several Application templates, and augments the README with Terraform-driven provisioning instructions.

• Add a cloud toggle and values directory for cloud manifests; deprecate the certManagerExtras block.
• Introduce IngressRoute, ClusterIssuer, and Certificate resources under values/cloud.
• Update Application templates to conditionally include proxmox or cloud, add finalizers, and update the global targetRevision.
• Enhance README with unified GitOps guide and Terraform phases.
• Add a plaintext Cloudflare token secret and disable SSL verification in the test client.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
deployments/argo-apps/values/proxmox/secret.yaml	Commits a plaintext Cloudflare API token
client/test_client.py	Disables SSL certificate verification (verify=False)
deployments/argo-apps/values.yaml	Grammar in comments around proxmox vs cloud toggle
deployments/argo-apps/templates/cloud.yaml	Adjusted Helm if directive syntax and indentation
deployments/argo-apps/values/traefik.yaml	Retains large blocks of commented-out configuration

Comments suppressed due to low confidence (3)

deployments/argo-apps/values.yaml:49

• [nitpick] This comment has grammatical errors—consider rewording to: “Enable either proxmox or cloud; they cannot be enabled simultaneously.”

# Must be enabled one or the another. Can not be enabled simultaneously

deployments/argo-apps/templates/cloud.yaml:1

• The Helm directive was un-indented by dropping the leading -. Verify that this template still renders correctly and that whitespace trimming works as intended.

{{- if .Values.applications.cloud.enabled }}

deployments/argo-apps/values/traefik.yaml:3

• [nitpick] Consider removing or archiving commented-out blocks if they’re no longer needed to avoid clutter and confusion in the values file.

# Set default IP for proxmox rke2 cluster
# spec:
#   loadBalancerIP: "10.69.3.3"

[Copilot]

Storing a plaintext Cloudflare API token in Git exposes it publicly. Consider using SealedSecrets, HashiCorp Vault, or Kubernetes External Secrets to keep tokens encrypted at rest and out of version control.

[Copilot]

Disabling SSL verification poses a man-in-the-middle risk. It’s better to configure proper CA certificates or trust settings rather than setting verify=False.

Suggested change

	API_URL, json=transaction_data, headers=headers, verify=False
	API_URL, json=transaction_data, headers=headers